4 Mar
2016
4 Mar
'16
7:27 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, master has been updated
via 173ef90a539dc33bb8fc395c0315320a4525a8d6 (commit)
via fd263b0dfd0ec44216c607b96e167f1027e404c6 (commit)
via 99db40ad2d4bf0569fc460d90132a64724a83a6c (commit)
from 22d7e75e1f160e5337140d9f3dcb2679b621b646 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=173ef90a539dc33bb8fc395c0315320…
commit 173ef90a539dc33bb8fc395c0315320a4525a8d6
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Mar 4 17:54:09 2016 +0100
pcu: Fix compiler warning about using string
Make the gsmtap hostname const to avoid turning a constant into
a mutable character. We never tried to modify the string so the
warning didn't reveal a genuine issue.
pcu_main.cpp:49:28: warning: deprecated conversion from string constant to ‘char*’
[-Wwrite-strings]
static char *gsmtap_addr = "localhost"; // FIXME: use gengetopt's
default value instead
http://cgit.osmocom.org/osmo-pcu/commit/?id=fd263b0dfd0ec44216c607b96e167f1…
commit fd263b0dfd0ec44216c607b96e167f1027e404c6
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Mar 4 18:24:50 2016 +0100
tbf: Fix copy and paste in the set_mode routine
This is the second attempt to fix what looks like a copy and paste
issue. The code assigns m_current_cs_ul and then compares the _dl
variant, then assigns m_current_cs_ul with a default value. It seems
to indicate that _ul should be used.
Fixes: Coverity: CID 1351733
http://cgit.osmocom.org/osmo-pcu/commit/?id=99db40ad2d4bf0569fc460d90132a64…
commit 99db40ad2d4bf0569fc460d90132a64724a83a6c
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Mar 4 18:19:02 2016 +0100
Revert "Refactor coding scheme assignment code"
Roll-out the refactoring change. The code did not include the
necessary update to the test result and there are some concerns
about it in itself and the right approach would have been to
fix the copy and paste issue, then do the refactoring.
This reverts commit 22d7e75e1f160e5337140d9f3dcb2679b621b646.
-----------------------------------------------------------------------
Summary of changes:
src/gprs_ms.cpp | 65 ++++++++++++++++++++++++++++----------------------------
src/pcu_main.cpp | 2 +-
2 files changed, 33 insertions(+), 34 deletions(-)
hooks/post-receive
--
UNNAMED PROJECT