21 Aug
2015
21 Aug
'15
7:12 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".
The branch, jerlbeck/testing/pcu has been updated
discards 769e802fc1114541013e2f2c058b2754a2b33a97 (commit)
discards 118347847897bacb76d76d85e110ffb129defd5c (commit)
discards fa8d07c9f33db7a8ce1b28377a0e474fc57176d9 (commit)
discards 5d34536fcf205a4acda28a2b03d27d3701420513 (commit)
via 25fde0c5212a2e47d48ff071e5019136cb5cdead (commit)
via ad1f92b1d4f7d49a4d107346e91c3a08ebde077c (commit)
via c0de4ae68e7974b3e7e90bd97ddf763f53839936 (commit)
via 32182f081d78ae27905fb731a8144258196eca2b (commit)
via 367cca831bd5cfc68a4635e89c692c29d3ead8be (commit)
via ce932198e82c24c086dd4fd37e378fef94006d71 (commit)
via 0e92b3479f232309c7b0eb8c8c319940f9809619 (commit)
via 490b94f6e9323d7627f43570698c58b508727d80 (commit)
via 449be1c14f57399db9390c2d2d23511466da8b04 (commit)
via 56f99d19c310b90632ac9b0b12898f4882f1020c (commit)
via e0b21f41c2b66d3f06a9aea5ac397857832671c8 (commit)
via 257b630216f0dc702013ecc51ac680b5296ae898 (commit)
via e91bd3babd5c04a154f296607b401a5050dcba31 (commit)
via b139598b1c5bd271675386be77370899b5707d61 (commit)
via 076f5c794d4af02914cd633671176437367b5af8 (commit)
via 537b149828be91189f99acc8d9c655b8a75b95ee (commit)
via 4a6fe534ce39b87f64a9b2013b654b92e6d7737d (commit)
via 2b349b5d33050f6484c375e545ecb9f05a6be961 (commit)
via ebebad1c92e8bcbe28780b4d5ee2ac32091089ff (commit)
via 56af6d55ed50c34d28e49c16f7c00da5820d22f3 (commit)
via f76fedeed5bb52f5ee471b2cabc9fb7aa0c4ccf8 (commit)
via fea17f8b8cc4835c9a92dfa018e38de0d6fc8cb5 (commit)
via af9a39d9542c1f4f337fe2cc5596000eb2c60d53 (commit)
via 28c40b17574a2dc792278baffb6f4f87e3559bb6 (commit)
via 3449a61032cbf91f1a042e02264142b4df3d61a7 (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (769e802fc1114541013e2f2c058b2754a2b33a97)
\
N -- N -- N (25fde0c5212a2e47d48ff071e5019136cb5cdead)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=25fde0c5212a2e47d48ff071e501913…
commit 25fde0c5212a2e47d48ff071e5019136cb5cdead
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Aug 20 11:48:30 2015 +0200
WIP tests and fixes TODO
TODO:
- check whether the semantics have not changed an put it away
http://cgit.osmocom.org/osmo-pcu/commit/?id=ad1f92b1d4f7d49a4d107346e91c3a0…
commit ad1f92b1d4f7d49a4d107346e91c3a08ebde077c
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 16:02:11 2015 +0200
ms/vty: Show LLC queue octets and packets in both views
Currently the per IMSI/TLLI view only shows the number of packets and
the 'all' view does not show any LLC related information at all. This
has proved to be annoying while debugging on a running system.
This commit adds the number of packets to the 'all' view and the
number of octets to both views.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=c0de4ae68e7974b3e7e90bd97ddf763…
commit c0de4ae68e7974b3e7e90bd97ddf763f53839936
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 15:46:16 2015 +0200
ms/vty: Show old TBFs
This commit extends the 'show ms imsi|tlli' command to show the old
TBFs, too.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=32182f081d78ae27905fb731a814425…
commit 32182f081d78ae27905fb731a8144258196eca2b
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 15:24:02 2015 +0200
ms: Store references to replaced TBFs in the MS object
Currently when calling GprsMs::attach_tbf and a TBF of the same
direction already exists, the old TBF gets detached from the MS
object.
Therefore that TBF object loses access to that MS object including
for instance TLLI and IMSI.
This leads to failing DL TBF reuses, since the downlink assigment
cannot be sent on the PACCH later on because that must be sent on the
old DL TBF which ms() is NULL and the new DL TBF cannot be retrieved.
This commit fixes this bug by changing the GprsMs implementation to
keep a list of replaced (old) TBFs. TBFs are only removed when they
are being detached explicitely (see tbf_free and set_ms).
Addresses:
tbf.cpp:741 We have a schedule for downlink assignment at uplink
TBF(TFI=1 TLLI=0xf35a680e DIR=UL STATE=RELEASING), but there is no
downlink TBF
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=367cca831bd5cfc68a4635e89c692c2…
commit 367cca831bd5cfc68a4635e89c692c29d3ead8be
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 15:10:23 2015 +0200
bssgp: Only call bssgp_tx_llc_discarded if the bctx exists
While this does not happen in real use, and unset btcx can lead to
segfaults in test cases. The other code outside of gprs_bssgp_pcu.cpp
does not depend on bctx being non-NULL:
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=ce932198e82c24c086dd4fd37e378fe…
commit ce932198e82c24c086dd4fd37e378fef94006d71
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 12:05:30 2015 +0200
llist: Add missing const qualifier in llist cast method
The missing const qualifier prevents the llist_empty() C++ wrapper
function from being compiled successfully when it is used.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=0e92b3479f232309c7b0eb8c8c31994…
commit 0e92b3479f232309c7b0eb8c8c319940f9809619
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Aug 20 17:49:03 2015 +0200
tbf: Use C++/talloc magic to support TBF constructors/destructors
The TBF object are currently created by using talloc_zero/talloc_free
directly from plain functions. Therefore C++ constructors and destructors
are not called. So the only initialisation that is done is setting
every member to 0. Non POD members do not have their constructors
called either, which makes it impossible to use the current LListHead
class for real members when the LListHead::m_back member has to be set.
This commit changes the TBF allocation functions to call the
corresponding C++ constructor after the call to talloc_zero and to
register the C++ destructor with the talloc context, so that is is
called before talloc_free actually frees the memory.
With this change, non-POD members and custom
constructors/desctructors can be used with gprs_rlcmac_tbf,
gprs_rlcmac_dl_tbf, and gprs_rlcmac_ul_tbf.
Note that this change is only a single step of the plan to turn the
TBF classes into real C++ classes.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=490b94f6e9323d7627f43570698c58b…
commit 490b94f6e9323d7627f43570698c58b508727d80
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 15:04:39 2015 +0200
tbf/test: Add test_tbf_dl_reuse
This tests the usage of an existing TBF that is no longer in FLOW
state to request a new DL TBF via the old TBF's PACCH.
The test triggers a bug that breaks the association between both TBF
objects, resulting in packet loss and transmission stalling.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=449be1c14f57399db9390c2d2d23511…
commit 449be1c14f57399db9390c2d2d23511466da8b04
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 15:03:23 2015 +0200
tbf/test: Fix tests, send real UL messages (TODO)
TODO: Merge with tests
http://cgit.osmocom.org/osmo-pcu/commit/?id=56f99d19c310b90632ac9b0b12898f4…
commit 56f99d19c310b90632ac9b0b12898f4882f1020c
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Thu Aug 20 15:55:56 2015 +0200
tbf/test: Move UL MAC block encoding into a separate function
This commits adds send_ul_mac_block() to encode and send a
RlcMacUplink_t to the PCU.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=e0b21f41c2b66d3f06a9aea5ac39785…
commit e0b21f41c2b66d3f06a9aea5ac397857832671c8
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 18:30:05 2015 +0200
tbf: Move pending LLC frames when merging MS objects
Currently the pending LLC packets are lost in some cases when MS
objects are merged, for instance after a RACH when there were 2 MS
object for the same MS (they get merged, when the TLLI is known for
both objects).
This patch modifies GprsMs::merge_old_ms to move all pending LLC
packets (if there are any) to the current MS object.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=257b630216f0dc702013ecc51ac680b…
commit 257b630216f0dc702013ecc51ac680b5296ae898
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 18:07:47 2015 +0200
llc: Add move_and_merge method to llc_queue
This methods takes all LLC frames from the old LLC queue and moves
them into the current. If both queues are ordered chronologically
(recv_time), the resulting queue is also ordered.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=e91bd3babd5c04a154f296607b401a5…
commit e91bd3babd5c04a154f296607b401a5050dcba31
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 18:19:29 2015 +0200
tbf: Do not kill DL TBF on Packet Resource Request
Currently all active TBF of an MS are killed if a Packet Resource
Request is received from the MS. In general this happens after a RACH
request. This does not happen after a resource request that has been
included into a Downlink Ack/Nack.
Sometimes an UL TBF is requested by an MS via RACH while a DL TBF is
running for instance to send a TCP Ack. This can happen, if a former
request via PACCH did not work.
This commit removes the killing of the DL TBF from
gprs_rlcmac_pdch::rcv_resource_request().
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=b139598b1c5bd271675386be7737089…
commit b139598b1c5bd271675386be77370899b5707d61
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 18:15:38 2015 +0200
tbf/test: Add tests for RACH while DL TBFs are active
This adds tests for
- RA update with RACH for the RAUpdateComplete message
- RACH for UL while DL is active (LLC queue not empty)
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=076f5c794d4af02914cd63367117643…
commit 076f5c794d4af02914cd633671176437367b5af8
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 18:00:54 2015 +0200
tbf/test: Fix existing tests
This commit fixes several issues:
- Set MS class in request
- Set IMSI in establish_ul_tbf_two_phase
- Fake assigment acknowledgement in establish_ul_tbf_two_phase
- Fix TFI bit offset to 1 (was 2)
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=537b149828be91189f99acc8d9c655b…
commit 537b149828be91189f99acc8d9c655b8a75b95ee
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Fri Aug 21 17:52:07 2015 +0200
tbf: Fix typos in log messages concerning UL/DL
The TBF in create_dl_ass can be of any direction. The text in
rcv_resource_request uses DL instead of UL.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=4a6fe534ce39b87f64a9b2013b654b9…
commit 4a6fe534ce39b87f64a9b2013b654b92e6d7737d
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Wed Aug 19 14:00:43 2015 +0200
tbf/test: Move UL TBF establishment into separate functions
Currently the functions test_tbf_single_phase and test_tbf_two_phase
do the test logging, BTS intialisation, and the complete message
sequencing on their own. Therefore they cannot be used to test more
complex sequences like TBF reestablishment.
This commit moves the code that does the actual messaging into own
functions. The frame number handling is generalised which also fixes
a block number wrapping error on the way.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/osmo-pcu/commit/?id=2b349b5d33050f6484c375e545ecb9f…
commit 2b349b5d33050f6484c375e545ecb9f05a6be961
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Aug 18 11:55:03 2015 +0200
ms: Move MS information merging to GprsMS
Currently the merging of the meta information (MS class, IMSI) takes
place in gprs_rlcmac_tbf::merge_and_clear_ms(). This makes it
difficult to merge the internal state and does not directly relate to
TBFs anyway.
This commit moves this into a new method GprsMs::merge_old_ms.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
src/bts.cpp | 15 +-
src/bts.h | 6 +
src/cxx_linuxlist.h | 2 +-
src/gprs_bssgp_pcu.cpp | 30 +
src/gprs_bssgp_pcu.h | 1 +
src/gprs_debug.cpp | 1 +
src/gprs_debug.h | 1 +
src/gprs_ms.cpp | 48 +-
src/gprs_ms.h | 12 +-
src/llc.cpp | 53 ++
src/llc.h | 1 +
src/pcu_main.cpp | 1 +
src/pcu_vty.c | 2 +-
src/pcu_vty.h | 2 +-
src/pcu_vty_functions.cpp | 15 +-
src/tbf.cpp | 50 +-
src/tbf.h | 11 +
src/tbf_dl.cpp | 5 +-
tests/llc/LlcTest.cpp | 53 +-
tests/llc/LlcTest.err | 5 +
tests/llc/LlcTest.ok | 2 +
tests/llist/LListTest.cpp | 4 +
tests/ms/MsTest.cpp | 28 +-
tests/ms/MsTest.err | 2 +-
tests/tbf/TbfTest.cpp | 586 ++++++++++++++++---
tests/tbf/TbfTest.err | 1432 ++++++++++++++++++++++++++++++++++++++++++++-
tests/tbf/TbfTest.ok | 8 +
27 files changed, 2235 insertions(+), 141 deletions(-)
hooks/post-receive
--
UNNAMED PROJECT