openbsc.git branch master updated. 0.13.0-901-g120250a

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 120250ad6fe8d2b641b716d5b37d48b125db23ca (commit) via 306bb993aab07f115ff6cbc89d81f862e08f7c32 (commit) via 3e4e58f349c201a2ed02971ef95051773fcef39b (commit) via 3ee67ff5c2f9da513c77b8ab9dfc0067296dadec (commit) via abb347853317427a227592c4fa4b38e99f9e7152 (commit) from 496aee7cb809069133fe37f39ccac7607ec6c9b3 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=120250ad6fe8d2b641b716d5b37d48b1… commit 120250ad6fe8d2b641b716d5b37d48b125db23ca Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Tue Jan 20 09:25:43 2015 +0100 gbproxy: Remove dummy definition of subscr_put The definition of subscr_put in gb_proxy_main.c will break linking if symbols from libcommon are used. Since subscr_put is in libcommon, there is no need for this dummy definition anymore. This patch removes the dummy definition. Adresses: ../../src/libcommon/libcommon.a(gsm_subscriber_base.o): In function `subscr_put': /home/jerlbeck/git/build/openbsc/openbsc/src/libcommon/gsm_subscriber_base.c:90: multiple definition of `subscr_put' gb_proxy_main.o:/home/jerlbeck/git/build/openbsc/openbsc/src/gprs/gb_proxy_main.c:56: first defined here Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=306bb993aab07f115ff6cbc89d81f862… commit 306bb993aab07f115ff6cbc89d81f862e08f7c32 Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Mon Jan 26 13:41:11 2015 +0100 sgsn: Don't reset mm->subscr manually in sgsn_mm_ctx_free Currently the sgsn_mm_ctx_free contains code to reset the mm->subscr field that is also present in gprs_subscr_cleanup, which is called directly afterwards. This commit modifies the code path, so that the cleanup is done by the gprs_subscr_cleanup function. The additional reference counter increment is needed, since mm->subscr->mm->subscr (which is the same like mm->subscr) will be reset (and unref'd) within gprs_subscr_cleanup. Because the local variable subscr in sgsn_mm_ctx_free is an additional pointer to the subscriber object, it is consequent to adjust the reference counter when the assignment is done. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3e4e58f349c201a2ed02971ef9505177… commit 3e4e58f349c201a2ed02971ef95051773fcef39b Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Mon Jan 26 11:07:24 2015 +0100 gprs: Rename gprs_subscr_delete to gprs_subscr_cleanup The old name is somewhat misleading. The function is rather preparing the subscriber for a subsequent subscr_free, that is possibly invoked by a subscr_put. It detaches the subscriber from the MM context and optionally invokes a PURGE_MS procedure. Therefore the _cleanup suffix is chosen (see mm_ctx_cleanup_free). Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=3ee67ff5c2f9da513c77b8ab9dfc0067… commit 3ee67ff5c2f9da513c77b8ab9dfc0067296dadec Author: Jacob Erlbeck &lt;jerlbeck(a)sysmocom.de&gt; Date: Mon Jan 26 09:22:39 2015 +0100 gprs: Don't check for EINPROGRESS in gprs_gsup_client_create Currently, the return value of gsup_client_connect is checked whether it is < 0 and != -EINPROGESS. Since gsup_client_connect will only return a negative value on a few permanent errors (not including EINPROGRESS), rc is always != EINPROGRESS. This patch removes the explicit check againt -EINPROGRESS and just leaves the check rc < 0. Sponsored-by: On-Waves ehf http://cgit.osmocom.org/openbsc/commit/?id=abb347853317427a227592c4fa4b38e9… commit abb347853317427a227592c4fa4b38e99f9e7152 Author: Holger Hans Peter Freyther &lt;holger(a)moiji-mobile.com&gt; Date: Mon Jan 26 10:26:36 2015 +0100 gb_proxy: No need to copy optarg Fixes: Coverity CID 1206578 ----------------------------------------------------------------------- Summary of changes: openbsc/include/openbsc/gprs_sgsn.h | 2 +- openbsc/src/gprs/gb_proxy_main.c | 5 +---- openbsc/src/gprs/gprs_gsup_client.c | 2 +- openbsc/src/gprs/gprs_sgsn.c | 6 ++---- openbsc/src/gprs/gprs_subscriber.c | 4 ++-- openbsc/tests/sgsn/sgsn_test.c | 6 +++--- 6 files changed, 10 insertions(+), 15 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)