29 Feb
2016
29 Feb
'16
2:34 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via 5dd3f1dd67a41fb46f2fcb6b58068525cda0a8a0 (commit)
via 79599acd663f7c488560d72d63f4e29587fc63a2 (commit)
via e0dc6a1c7cd49433bdf592624ff484576a7ce4e4 (commit)
via 64e0eb56fde45d891da122c9685891d29634d03b (commit)
via a89d22c0f08edda927ce62b071f17bd7e5edc5c6 (commit)
via de6dd72dbbbcc7facf25c4a2521c71f653c7b1b2 (commit)
from f20f5fd5085879624fb6de1e5b9b5ad435ea0500 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=5dd3f1dd67a41fb46f2fcb6b5806…
commit 5dd3f1dd67a41fb46f2fcb6b58068525cda0a8a0
Merge: f20f5fd 79599ac
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Feb 29 14:34:34 2016 +0100
Merge branch 'sysmocom/shared/log-speed'
http://cgit.osmocom.org/libosmocore/commit/?id=79599acd663f7c488560d72d63f4…
commit 79599acd663f7c488560d72d63f4e29587fc63a2
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Fri Jan 15 16:49:06 2016 +0100
logging: Move the filter check up as well
There doesn't seem to be a reason not to check the filter. Update
and extend the test. Currently the filter function will be called
once for the log check and once for the output of it.
http://cgit.osmocom.org/libosmocore/commit/?id=e0dc6a1c7cd49433bdf592624ff4…
commit e0dc6a1c7cd49433bdf592624ff484576a7ce4e4
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Mon Dec 21 14:45:16 2015 +0100
logging: Remove some code duplication
Extract the mapping of the subsystem number and the checking for
the loglevel to a inline method that is shared between the new
and old.
http://cgit.osmocom.org/libosmocore/commit/?id=64e0eb56fde45d891da122c96858…
commit 64e0eb56fde45d891da122c9685891d29634d03b
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 17 11:52:26 2015 +0100
log/test: Extend test case for log_check_level
This commit adds OSMO_ASSERTs for mandatory conditions related to
log_check_level, and fprintfs for optional conditions, since it is
always safe for log_check_level to return != 0.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/libosmocore/commit/?id=a89d22c0f08edda927ce62b071f1…
commit a89d22c0f08edda927ce62b071f17bd7e5edc5c6
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 17 11:52:25 2015 +0100
log: Add conditional logging based on log_check_level
Currently the LOGP/DEBUGP arguments are always evaluated even if
no logging will happen at all. This can be expensive, for instance
if hexdumps or pretty printed object names are generated. This causes
high base load especially on embedded devices and is a major part of
CPU usage e.g. of the osmo-pcu.
This commit uses the log_check_level function to avoid the evaluation
of the parameters if it is known in advance, that no logging entry
will be generated.
Sponsored-by: On-Waves ehf
http://cgit.osmocom.org/libosmocore/commit/?id=de6dd72dbbbcc7facf25c4a2521c…
commit de6dd72dbbbcc7facf25c4a2521c71f653c7b1b2
Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de>
Date: Tue Nov 17 11:52:24 2015 +0100
log: Add log_check_level function
This commit adds this predicate function which can be used to
avoid the execution of code if a certain log level is not enabled.
The function will only return 0 (false), if it is sure that a logging
call for the same facility and level will not produce any output.
This safety criterion shall ensure, that no logging output is lost
due to the use of this predicate as a guard. On the other hand, even
if the predicate returns != 0 (true), no logging output might get
generated by a similar logging command.
Note that the current implementation is not focussed on performance,
which could be improved by using a lookup table instead of iterating
through every target.
Sponsored-by: On-Waves ehf
-----------------------------------------------------------------------
Summary of changes:
include/osmocom/core/logging.h | 25 +++++++++--
src/logging.c | 95 +++++++++++++++++++++++++++++-------------
tests/logging/logging_test.c | 19 ++++++++-
tests/logging/logging_test.err | 1 +
4 files changed, 106 insertions(+), 34 deletions(-)
hooks/post-receive
--
An utility library for Open Source Mobile Communications