openbsc.git branch neels/iu created. 0.15.0-784-g758c6c478

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/iu has been created at 758c6c478d787a59983c80896c4fabb69b679fd1 (commit) - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=758c6c478d787a59983c80896c4fabb6… commit 758c6c478d787a59983c80896c4fabb69b679fd1 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Mar 2 02:37:39 2017 +0100 wip Change-Id: I4101b102145a011cec1eb8b92863f38ff7db57b2 http://cgit.osmocom.org/openbsc/commit/?id=9d10f424de3c7bca7c323439332deeaa… commit 9d10f424de3c7bca7c323439332deeaae4bd642b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Mar 2 02:22:58 2017 +0100 mark fixme: rate counters Change-Id: I45651fd4cf3f4da8ad67251bbb3b627888e76d9c http://cgit.osmocom.org/openbsc/commit/?id=1380a1f9ab193e8cdbdaa03bf46aa07b… commit 1380a1f9ab193e8cdbdaa03bf46aa07bb85bcbde Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Oct 21 01:32:10 2016 +0200 mgcp: log payload type change Change-Id: Iee5fa667dece12174b1933345c1ed640a264ed97 http://cgit.osmocom.org/openbsc/commit/?id=7405922b092e5bd38b451e06176494db… commit 7405922b092e5bd38b451e06176494db4a3c881f Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Jan 23 16:56:02 2017 +0100 comment: fixme: rab failure Change-Id: I6e21f2d7dd560ab15675f3e432c37a13c4ab6792 http://cgit.osmocom.org/openbsc/commit/?id=459f46f6e3a1b7062ad27c85e208f289… commit 459f46f6e3a1b7062ad27c85e208f289bac57c06 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Oct 18 20:20:51 2016 +0200 mgcp parsing, set port from mgcp response Change-Id: I90e2c1aa7575d5fa6e0374f5022cbb25fc3f7699 http://cgit.osmocom.org/openbsc/commit/?id=88507500d51c062103f9c7dff3094189… commit 88507500d51c062103f9c7dff30941896d3276a3 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Oct 18 18:38:59 2016 +0200 mgcp parsing, mgcp test Change-Id: Ibe2ab17b3fa3a506a2e841ba979ea4175e3a21e8 http://cgit.osmocom.org/openbsc/commit/?id=222faa8213fac638877d5a6272b67ba3… commit 222faa8213fac638877d5a6272b67ba34f3bb969 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Oct 14 17:56:17 2016 +0200 mgcp: handle responses from the MGCP GW Change-Id: I5c0493feaec775461b5a017c36b93cc2ad63c896 http://cgit.osmocom.org/openbsc/commit/?id=c67c63e5303307f94512f0fbb1775030… commit c67c63e5303307f94512f0fbb1775030789c8ea2 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Oct 12 02:53:55 2016 +0200 IuPS: cosmetic: explicitly check RAN type; move comment Change-Id: I8375ba42dd47d7ccd9ce9290767d6f8653a23b94 http://cgit.osmocom.org/openbsc/commit/?id=00b0a9fa3a352e71e24ee1806f9b2af5… commit 00b0a9fa3a352e71e24ee1806f9b2af5fc950c2d Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Oct 12 01:39:25 2016 +0200 IuCS and IuPS: add VTY config for RAB Assignment address kind To accomodate the ip.access nano3G without having to recompile, make the RAB Assignment's Transport Layer Address IE's format configurable, in both osmo-msc and osmo-sgsn. The long term perspective is to somehow detect which address encoding a given 3G cell prefers, but for the time being just configure it globally and set each ue_conn_ctx to the global setting upon creation. Add VTY command to iu_vty.c, with args passed to iu_vty_init() to insert at an arbitrary VTY node, so that it can be used both for osmo-msc and osmo-sgsn. Add generic iu_vty_config_write() to write out the config. Call iu_vty_init() from msc_vty_init(); msc_vty_init() is in libmsc, hence linking of osmo-msc now needs libiu to come after libmsc, so move that further down. Change-Id: I93728314742b327336f3fb6de98e6457f687e1f9 http://cgit.osmocom.org/openbsc/commit/?id=6a28e2b038e301685fe38b617cf4faa1… commit 6a28e2b038e301685fe38b617cf4faa17b66e087 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Oct 12 02:55:31 2016 +0200 IuCS, IuPS: move flag to use X.213 NSAP addr into ue_conn_ctx The future perspective is to remember the preferred RAB Transport Layer Address encoding for each 3G cell that is connected, so store per UE conn instead of globally hardcoding. Add rab_assign_addr_enc member to ue_conn_ctx. Thus the iu_rab_act_cs() and iu_rab_act_ps() functions no longer need the explicit use_x213_nsap argument. Add include/openbsc/common.h in order to define the enum nsap_addr_enc, in a separate file to be able to easily include it in all of libmsc, libiu and gprs/* without creating include cycles. Set the rab_assign_addr_enc when an MM ctx is created for iu, and whenever the ue_conn_ctx for an Iu MM ctx is updated. This looks a bit clumsy so far, the hope is that there will be a nice way to setup the ue_conn_ctx prior to that. Change-Id: I49bb5736df7bdfdd55d3e7b74ee559595cfd2f7d http://cgit.osmocom.org/openbsc/commit/?id=d55a5d7b52395ab3a0015ea4767a2604… commit d55a5d7b52395ab3a0015ea4767a26046daa9d5b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Oct 12 03:30:48 2016 +0200 sgsn init: pass sgsn_config pointer to sgsn_vty_init(), not sgsn_parse_config It makes sense semantically, and prepares for an upcoming commit that uses the internal global config pointer in sgsn_vty_init(), which would not be defined yet without this. Change-Id: Ie4cf1c0a1c9e6330a134ff4b7b2e6d5699c12bd7 http://cgit.osmocom.org/openbsc/commit/?id=e19a6d5b68efcac1b73c17f8f7f6ef7d… commit e19a6d5b68efcac1b73c17f8f7f6ef7dda041070 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Oct 12 01:29:33 2016 +0200 iu: sort out confusion around asn_debug and asn1_xer_print Before, I confused asn_debug with asn1_xer_print. Have two distinct VTY commands and fix documentation. Put the asn_debug and asn1_xer_print implementations in iu.c. Since they are globally defined, don't pass a pointer to iu_vty_init() but just use it directly. Might be considered less clean, but is also less bloat. Change-Id: Iccbadfe1585ba224f74cdfb5273b5ce29b6d78f0 http://cgit.osmocom.org/openbsc/commit/?id=08de61a0be444e94f3ff332420e80f61… commit 08de61a0be444e94f3ff332420e80f6181012080 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Oct 12 01:48:55 2016 +0200 iu.h: add missing includes and type defs So far it was included only in files that also include all needed headers, but make it so that it can be included on its own. Change-Id: I08a756031b995bd01a6e15c678b845fd98de960b http://cgit.osmocom.org/openbsc/commit/?id=7f22416aafa36e9169a908568f2cb3f4… commit 7f22416aafa36e9169a908568f2cb3f4d046c30c Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Oct 11 02:24:53 2016 +0200 IuCS: rapidly release connections Do the same as we do in 2G: release the connection as soon as nothing else is pending for a given subscriber. Before, osmo-msc would wait for the UE "to get bored" and send an Iu release. But the CN should stay lean on connections. Also, 25.413[1] in section 7, 6th point states: "While the Iu release is managed from the CN, the RNC has the capability to request the release of all Iu connection resources from the corresponding Iu connection." So far we did not manage Iu release from osmo-msc at all. Use the same mechanism we use in 2G: from msc_release_connection(), just before freeing the gsm_subscriber_conn, invoke a CN initiated Iu Release command to the UE. This works around OS#1816 ("USSD only works when IuCS is released", on nano3G), because the Iu conn is now released right after every signalling, so that typically no two requests will use the same conn. In iu.h/iu.c, add iu_tx_release(), absorbing almost all of the code from ranap_handle_co_iu_rel_req(). Add stub to db_test.c, necessary to build it without linking libiu. [1] 3GPP TS 25.413 v12.4.0 Release 12 / ETSI TS 125 413 V12.4.0 (2015-04) Related: OS#1816 Change-Id: Ic12bd6f3666f6fd42bd6d9fdae1c93abee3b6786 http://cgit.osmocom.org/openbsc/commit/?id=48c1999bf20209ed794fdcba428b48c4… commit 48c1999bf20209ed794fdcba428b48c4bb4464af Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Oct 11 00:50:05 2016 +0200 IuCS: don't remove Iu conn until release Don't remove the gsm_subscriber_connection without an Iu Release. From the 2G paradigm to close a subscriber connection as soon as nothing else is pending, osmo-msc frequently calls msc_release_connection() to see whether a conn has anything pending, or discards it. In 3G however, we so far don't actively release IuCS connections from the MSC side, but wait until the IuCS is released from the UE side. So the conn is often discarded even though the IuCS stays open and valid, which confuses the situation: before the UE releases a bit later, we would try to page the subscriber unsuccessfully, because the UE expects to already be connected. To first fix the discrepancy of Iu vs. subscr release, never discard gsm_subscriber_connections when msc_release_connection() is called. This creates a "lazy" CN that keeps connections open as long as the UE will tolerate. It is really fast in sending many SMS in close succession, but is certainly a bad CN design choice: we should rather stay lean on connections. A subsequent commit will change this, but I decided to keep this commit as a reference, for when we'd like to test situations that should re-use an established connection. Change-Id: I012378cfa432d791146db387554ec1909de05297 http://cgit.osmocom.org/openbsc/commit/?id=2e0063e08226beb96a23c5731b26fd4b… commit 2e0063e08226beb96a23c5731b26fd4b2315b463 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Sep 20 18:18:26 2016 +0200 mgcp dbg log Change-Id: I56fda48edaa92abfc6e3886cdfce733bb0686f73 http://cgit.osmocom.org/openbsc/commit/?id=2fcaf4a1aab6c4bf3a3d250952dac39f… commit 2fcaf4a1aab6c4bf3a3d250952dac39fcbede636 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Sep 22 20:00:16 2016 +0200 sgsn_ranap_iu_event: handle some events without valid MM context Change-Id: Ia7e74087d56996104b6d3935b1cf12166ff67f3a http://cgit.osmocom.org/openbsc/commit/?id=be96261548f2e78bacd3ae95335d135f… commit be96261548f2e78bacd3ae95335d135f15498deb Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Sep 19 18:30:49 2016 +0200 IuCS: store assigned rab_id in gsm_subscriber_connection Change-Id: I7fda4304631fc24bbd1bebe911b8403a942fcf53 http://cgit.osmocom.org/openbsc/commit/?id=77d3e13e3410fd1e4114cfe6b27005c2… commit 77d3e13e3410fd1e4114cfe6b27005c2ecebd43e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Sep 22 20:28:35 2016 +0200 bridge calls via mgcpgw Change-Id: Ie259e30bc532fe9817c96562022ac33443d5747a http://cgit.osmocom.org/openbsc/commit/?id=816423c24a59d768e9d92809c7fbb80d… commit 816423c24a59d768e9d92809c7fbb80dee50dc5b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Sep 22 20:29:30 2016 +0200 also do call assignment for MT calls, upon Call Confirmed Change-Id: I863fa73948f61aaffd7f4472f3abc3e44228e31f http://cgit.osmocom.org/openbsc/commit/?id=8debae5492f2268268fe32a239a7f974… commit 8debae5492f2268268fe32a239a7f974355976e5 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Sep 7 13:39:07 2016 +0200 IuCS: implement msc_call_assignment() for IuCS Send IuCS RAB Activation upon MNCC_CALL_PROC_REQ. Implement function msc_call_assignment(): decide between sending A-iface BSSMAP Assignment Request or IuCS RAB Assignment Request. Implement iu_rab_act_cs() to send the IuCS RAB Assignment Request. The IP address and port of the MGCPGW sent in the RAB Assignment are still hardcoded. The A-interface extension is not implemented yet. Declare ranap_new_msg_rab_assign_voice() to avoid including ranap_msg_factory.h, which would require adding ASN1 CFLAGS to Makefile.am. The mgcpgw_client as well as some more osmo-iuh functions are now linked from libmsc, hence add some dummy stubs to libiudummy and db_test.c. Change-Id: Iaae51d1fbbfc28fad1c0b85e161d53d80a420a19 http://cgit.osmocom.org/openbsc/commit/?id=754b2efadf54144d6a185d3311ca8c10… commit 754b2efadf54144d6a185d3311ca8c10b082150a Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Sep 22 20:21:10 2016 +0200 msc: add mgcpgw client (with dummy read cb so far) Store the mgcpgw client data in struct gsm_network. Initialize VTY and bind the client. Change-Id: Ifc4efb1ca44fa34c29bf23b35addb54155296d68 http://cgit.osmocom.org/openbsc/commit/?id=f7f9d9dd6405d865d8c83b1236e94feb… commit f7f9d9dd6405d865d8c83b1236e94feb1b8edc72 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Sep 7 13:39:07 2016 +0200 libmgcp: add mgcpgw client API Add an API to send MGCP messages to an MGCP GW, from the perspective of an MSC instructing the GW to setup RTP streams. Rationale: the mgcp_protocol.h is mostly for the MGCP GW itself, other implementations forward incoming MGCP messages. So a simpler approach for an MGCP GW client is useful. Add general VTY commands that can be used to configure mgcpgw_client. osmo-msc is going to use this to route RTP streams (for 3G at first). Change-Id: I6fe365c4c89207f2172943cc456b508a207b1135 http://cgit.osmocom.org/openbsc/commit/?id=8fdb920168840bf6a8f18569e7ddb445… commit 8fdb920168840bf6a8f18569e7ddb445fee66522 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Sep 7 13:39:07 2016 +0200 libmgcp: add value strings for mgcp_connection_mode Add file mgcp_common.c to implement the value strings for the mgcp_connection_mode. Add in a separate file because of the upcoming mgcpgw_client.c implementation, introducing a file that contains implementations commonly used in MGCP GW as well as its clients. Change-Id: I6fe365c4c89207f2172943cc456b508a207b1135 http://cgit.osmocom.org/openbsc/commit/?id=9e4f71b091988a22ba3d8d706ce6d4bb… commit 9e4f71b091988a22ba3d8d706ce6d4bb46ee1670 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Sep 20 18:16:35 2016 +0200 libmgcp: move mgcp_connection_mode to public header mgcp_connection_mode will be used by the upcoming mgcpgw_client.h API. Change-Id: I7a3f8905723320d968f1a53c1036904107b4fb2d http://cgit.osmocom.org/openbsc/commit/?id=c94e1b68b025af6d5e4912b4740fa2ec… commit c94e1b68b025af6d5e4912b4740fa2ecc3e126f4 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Sep 6 20:08:58 2016 +0200 IuCS: cosmetic prep for msc_call_assignment() Rename gsm48_cc_tx_call_proc() to gsm48_cc_tx_call_proc_and_assign() to mark the place where the A-interface will send a BSSAP Assignment Request / where the IuCS-interface will send a RAB Assignment Request. Add function msc_call_assignment() to decide between A-iface and IuCS assignment, to be implemented in subsequent commit. Change-Id: I0695e233d57d13658793b0e63bb7c3ff224909a0 http://cgit.osmocom.org/openbsc/commit/?id=756ea325bd22ef8f98854bc91a9a117d… commit 756ea325bd22ef8f98854bc91a9a117dab735f88 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Sep 7 17:52:32 2016 +0200 IuCS: send RANAP CommonID Add libiu function to send a CommonID message down a UE connection, iu_tx_common_id(); add also a corresponding stub to libiudummy for linking with tests. Add libmsc function msc_tx_common_id() to call the above. Add this mostly to clearly indicate in msc_ifaces.h that libmsc is calling out of the MSC; also to do conn->via_iface checking. Call msc_tx_common_id() after ciphering is established, in _gsm48_rx_mm_serv_req_sec_cb()'s GSM_SECURITY_SUCCEEDED case. Change-Id: I576ddd5bbabfc989149debd2f8a9743db6d26043 http://cgit.osmocom.org/openbsc/commit/?id=775f1c9b09d7a531c710bb80be52f7ac… commit 775f1c9b09d7a531c710bb80be52f7ace8eb1f72 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Aug 31 15:40:18 2016 +0200 cosmetic: msc_handler, bsc_handler: drop extra whitespace The extra ws made me not find these lines when grepping for 'dtap ='. Change-Id: I45e5c9e7df4704546872aab15adf407298943435 http://cgit.osmocom.org/openbsc/commit/?id=53c5edfc3c9e2b8e3804ce1e1e9fe955… commit 53c5edfc3c9e2b8e3804ce1e1e9fe9552e970532 Author: Harald Welte <laforge(a)gnumonks.org> Date: Mon May 2 08:34:57 2016 +0200 SGSN: Don't indicate GERAN in Iu mode PDP CTX ACT REQ to GGSN http://cgit.osmocom.org/openbsc/commit/?id=35e2f5195ef2094da7a49d8cff73718b… commit 35e2f5195ef2094da7a49d8cff73718b67bd54c0 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 9 13:20:54 2016 +0200 cosmetic: make gsm0408_loc_upd_rej() static http://cgit.osmocom.org/openbsc/commit/?id=56e2b5722161c37f23fa66eb4122f161… commit 56e2b5722161c37f23fa66eb4122f16143fa4e54 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 9 13:18:03 2016 +0200 LU counters: count completion and failure, not messages sent From a human admin viewpoint it doesn't make sense to count the messages sent: When we use TMSIs, we first send a LU Accept with a new TMSI, and then expect the MS to respond with a TMSI Realloc Complete message. When that fails to come through, the LU actually ends in failure, even though a LU Accept was sent. In 3G, if a UE sends an Iu Release during LU (e.g. user enables flight mode), we cancel the LU without sending any reply at all, so nothing would be counted. Instead, count Location Updating results, i.e. completion and failures. http://cgit.osmocom.org/openbsc/commit/?id=1d5f0f50f28d03f813def41d605a75d0… commit 1d5f0f50f28d03f813def41d605a75d09a5557eb Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 15:21:52 2016 +0200 remove handle_abisip_signal() Change-Id: I9cf80f9c2c8a53a29e42f000029e680a9922cb41 http://cgit.osmocom.org/openbsc/commit/?id=a0928566ae0cefa0f16b39d2fa518d99… commit a0928566ae0cefa0f16b39d2fa518d991272c007 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed May 4 15:35:37 2016 +0200 gsm0408_clear_request(): actually free the released conn By having conn->in_release == 1, calling msc_release_connection() has no effect and thus never frees the conn. So, after all pending requests have been discarded, also discard and free the unused connection. http://cgit.osmocom.org/openbsc/commit/?id=ad116ecce197d634682db42dd80d4498… commit ad116ecce197d634682db42dd80d4498af6f1a03 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 15:24:12 2016 +0200 add iu.h to gsm_subscriber.c Change-Id: I398aaa4a7328a58fb0d563725f3bea26482929ef http://cgit.osmocom.org/openbsc/commit/?id=c7be84ee605f7151a5dbbefca26e1b83… commit c7be84ee605f7151a5dbbefca26e1b83293b859d Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 15:11:39 2016 +0200 gsm_04_08.c: iu.h Change-Id: I624612b5d5cd70770326347634aee2a42ba88945 http://cgit.osmocom.org/openbsc/commit/?id=6c6804e25fb9df9b09e03cf7e23b0a7a… commit 6c6804e25fb9df9b09e03cf7e23b0a7a5448745f Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 15:09:47 2016 +0200 temporary dev: set debug log level almost everywhere Change-Id: I0d5a36560e7edde27497de57e579f5b1d00eb525 http://cgit.osmocom.org/openbsc/commit/?id=6919a1ac3d55252b497e2a78a8f95d18… commit 6919a1ac3d55252b497e2a78a8f95d187b566ff9 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue May 10 13:26:47 2016 +0200 comment on mscsplit, indent comment http://cgit.osmocom.org/openbsc/commit/?id=2f0f5aa460c219636a71a84987abd084… commit 2f0f5aa460c219636a71a84987abd08484d14b73 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue May 10 13:44:39 2016 +0200 move to libbsc: lchan_next_meas_rep() -- TODO really? Change-Id: I4ea799c5fa61f81c404e6ef1b9ac86a8faa1fb49 http://cgit.osmocom.org/openbsc/commit/?id=edf4b1b3ba74ad13bed225158789992b… commit edf4b1b3ba74ad13bed225158789992bfa2a3ed1 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue May 10 13:59:16 2016 +0200 move to libbsc: gsm_bts_neighbor() -- TODO really? Change-Id: I63d4835dc7aabdf176e0ca634a6a4ca527612693 http://cgit.osmocom.org/openbsc/commit/?id=1f0e68b9dc55ae6eabd89099eaf28c9f… commit 1f0e68b9dc55ae6eabd89099eaf28c9fac5578c0 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed May 11 14:21:58 2016 +0200 gsm0408_test: use NULL for root ctx -- TODO really? http://cgit.osmocom.org/openbsc/commit/?id=c4cfb7c0d44bd956949e84f90f08bb4b… commit c4cfb7c0d44bd956949e84f90f08bb4b89fe3473 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 9 21:30:26 2016 +0200 gsm_04_08: remove apply_codec_restrictions() -- TODO really? This function is wrongly placed on the MSC level. Unfortunately I cannot remember the very plausible details that hwelte had back in the days to argue for this change. (Refactoring an old commit that fails to explain in more detail.) Change-Id: I82623847e652a59a921d2fb142b77cf22420a746 http://cgit.osmocom.org/openbsc/commit/?id=0fde9499f3bc7132348135da7645be16… commit 0fde9499f3bc7132348135da7645be165b9bacf3 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu May 12 02:14:33 2016 +0200 move to libmsc: osmo_stats_vty_add_cmds() -- todo MSCSPLIT http://cgit.osmocom.org/openbsc/commit/?id=63fe2d6b7720053267de48c9695f0a44… commit 63fe2d6b7720053267de48c9695f0a4476f57e4d Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue May 10 14:04:28 2016 +0200 include msc_ifaces.h in gsm_04_08.c Change-Id: I11be1bdfe6993f89b34319e7d1526c729d6e0cde http://cgit.osmocom.org/openbsc/commit/?id=59c939203a2ba55bb5f8366bee70ba18… commit 59c939203a2ba55bb5f8366bee70ba18af45ef32 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 15:04:56 2016 +0200 complete IuCS paging implementation Add paging timeout to struct gsm_subscriber. Previously, paging timeout was implemented only on BSC level, where each request has its own timeout value. The MSC will still send individual requests to BSC or RNC level, where they timeout individually. However, the MSC must also have an own timeout to be sure to discard stale pagings that the BSC or RNC never replied for. Add handle_paging_resp(), copying the few libmsc relevant parts of gsm48_handle_paging_resp(). http://cgit.osmocom.org/openbsc/commit/?id=aac0e0bc9971a1bcc6b9c123c8521370… commit aac0e0bc9971a1bcc6b9c123c8521370317b3613 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue May 10 13:57:25 2016 +0200 paging: add todo comments for paging and mscsplit Change-Id: I7e72c9db2837ea5edf45f6037cb0288a264d492c http://cgit.osmocom.org/openbsc/commit/?id=68dc9e617aa62e7001ca80ce43cae52f… commit 68dc9e617aa62e7001ca80ce43cae52fdd493a7d Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 2 15:57:53 2016 +0200 paging: actually verify subscriber authorization Before this, any paging response would be accepted by the CN, without checking the database whether the subscriber is in fact authorized. The probability that a subscriber would be able to take unauthorized action is slim, nevertheless checking authorization status with the database should happen before we accept a connection. http://cgit.osmocom.org/openbsc/commit/?id=771d3bb82f60cd18c5d6f1c24f9c4e9b… commit 771d3bb82f60cd18c5d6f1c24f9c4e9bf87f8662 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 2 15:55:22 2016 +0200 paging: change subscr_paging_cb() into subscr_rx_paging_response() Remove one layer of callback indirection in paging. When a paging response arrives, we always want to first secure the connection, thus a fixed subscr_rx_paging_response() function is more appropriate and avoids having to store a cbfn. The actual actions to be taken upon successful paging are of course still in callback functions stored with each subscriber. Remove paging_request_stop() call from subscr_paging_dispatch(), which stops paging on all BTSs, which is not the responsibility of libmsc. Change-Id: Ic2c785c9cc48b2c2c6557cbe1060d25afa89e38d http://cgit.osmocom.org/openbsc/commit/?id=4be70d114036ca04563aa665477f6ed1… commit 4be70d114036ca04563aa665477f6ed1e523ceee Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Aug 12 16:03:09 2016 +0200 Iu auth wip Change-Id: I44effcca80dc6850178174dc957bcd5608b0ae14 http://cgit.osmocom.org/openbsc/commit/?id=428af2545a7ff43ae79b57ef082797bb… commit 428af2545a7ff43ae79b57ef082797bb2d990310 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 15:07:23 2016 +0200 subscr_request_channel() -> subscr_request_conn() Change-Id: Ife8e10b240693a8d369139881774f1892044aa65 http://cgit.osmocom.org/openbsc/commit/?id=ad0ea28ce6ce4c583e2b09be22aa1b21… commit ad0ea28ce6ce4c583e2b09be22aa1b2193630bea Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 15:05:13 2016 +0200 move subscr_request to gsm_subscriber.h Change-Id: Idbbd39b0e068da17aafa97e315143509c69c50ea http://cgit.osmocom.org/openbsc/commit/?id=6ee31c50ee582d755a1ea0c745853b08… commit 6ee31c50ee582d755a1ea0c745853b081c3c9212 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 15:01:01 2016 +0200 add gsm_encr to subscr_conn Change-Id: Id5797cd1f1bfa2cca2d3fbabc1981aa75546421b http://cgit.osmocom.org/openbsc/commit/?id=d6ed43b594f1ce2845e3e726604a8ea1… commit d6ed43b594f1ce2845e3e726604a8ea1f97eb8cb Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 14:57:14 2016 +0200 osmo-nitb becomes osmo-msc Change-Id: I3787050b524954d8a4dd13495c458f3ee293807b http://cgit.osmocom.org/openbsc/commit/?id=ea23766483cb40aa7bf5f0a61a67a83f… commit ea23766483cb40aa7bf5f0a61a67a83faa2aa745 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed May 11 17:13:28 2016 +0200 remove unneccessary linking from some tests The recent shifts and cuts have made some library linking for bsc, channel and db tests unnecessary. http://cgit.osmocom.org/openbsc/commit/?id=eb68dd7c692be656764d58907a73e35d… commit eb68dd7c692be656764d58907a73e35d3ef51c84 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 21:44:32 2016 +0200 cut off libbsc paging, pending paging in libmsc Temporarily disable all paging to be able to link libmsc without libbsc. Skip the paging part of channel_test because the paging is now disabled. In osmo-nitb, paging is done on BSC level and MSC level "at the same time". When the new MSC is fully operational, paging will be controlled separately on the MSC level, and the BSC (RNC) level will be instructed over an IuCS or A-interface to negotiate paging with the MS (UE). This MSC level paging does not yet exist and will be added in subsequent commits. Change-Id: I8b6920ddc54fc3f2876a59664e6722666d8a8a4a http://cgit.osmocom.org/openbsc/commit/?id=2bdb25354c70906dd1a14ae7f2ba07a9… commit 2bdb25354c70906dd1a14ae7f2ba07a96f244162 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 13:09:14 2016 +0200 libmsc: duplicate gsm0808 / gsm48 functions (towards BSC) In osmo-nitb, libmsc would directly call the functions on the BSC level, not always via the bsc_api. When separating libmsc from libbsc, some functions are missing from the linkage. Hence duplicate these functions to libmsc, add an msc_ prefix for clarity, also add a _tx to gsm0808_cipher_mode(): * add msc_gsm0808_tx_cipher_mode() (dummy/stub) * add msc_gsm48_tx_mm_serv_ack() * add msc_gsm48_tx_mm_serv_rej() Call these from libmsc instead of * gsm0808_cipher_mode() * gsm48_tx_mm_serv_ack() * gsm48_tx_mm_serv_rej() Also add a comment relatd to msc_gsm0808_tx_cipher_mode() in two places. Change-Id: I5b276853d3af71f5e3f0a031fd17b4fff0580020 http://cgit.osmocom.org/openbsc/commit/?id=3b1387a23f474e47570d3907369244f7… commit 3b1387a23f474e47570d3907369244f7b1d5d01e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri May 20 20:40:34 2016 +0200 Use new msc_tx_dtap() instead of gsm0808_submit_dtap() Aim: msc_tx_dtap() shall redirect to IuCS or A interfaces depending on subscr conn. Change-Id: I30d961f16eb7b9c0ab9cc3f43198098d3f1a909f http://cgit.osmocom.org/openbsc/commit/?id=517e0b402f6c592edaab16ab094a3c0a… commit 517e0b402f6c592edaab16ab094a3c0acd8ff139 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri May 20 21:41:08 2016 +0200 add libiudummy, to avoid linking Iu deps in tests Change-Id: I4a66c4122011dbc87c6fcb336ab0461b86522c98 http://cgit.osmocom.org/openbsc/commit/?id=834e25c96e84f193cd5518643cc4ef47… commit 834e25c96e84f193cd5518643cc4ef47b3a0777e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue May 10 14:59:02 2016 +0200 move to libcommon-cs: gsm48_extract_mi(), gsm48_paging_extract_mi() -- TODO move to libfilter instead? Change-Id: I00ca0caf8224de029f53f4dedb1146e3cf7650ec http://cgit.osmocom.org/openbsc/commit/?id=648f2a73b7d26767a7e0310345119871… commit 648f2a73b7d26767a7e0310345119871bbfbe0f9 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue May 10 13:37:59 2016 +0200 msc_compl_l3(): publish in .h, tweak return value Use new libmsc enum values for return val, to avoid dependency on libbsc headers. Make callable from other scopes: publish in osmo_msc.h and remove 'static' in osmo_msc.c Change-Id: If24007445899e9c75553a0dbf843ada3566b3380 http://cgit.osmocom.org/openbsc/commit/?id=7ac7edb123d3a8463ee59eb996936295… commit 7ac7edb123d3a8463ee59eb99693629513a0e3c0 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 14:58:46 2016 +0200 add msc vty, remove nitb vty Change-Id: I8f8980d6cfbf26f1b0e0197939833e55dbe521fb http://cgit.osmocom.org/openbsc/commit/?id=79c79a968723f46aadd74323d3cf5e2c… commit 79c79a968723f46aadd74323d3cf5e2cbeec4bc9 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 14:56:06 2016 +0200 add iucs.[hc] Change-Id: I88e981f4c31393a98ae8d61176c65c9251a6f28b http://cgit.osmocom.org/openbsc/commit/?id=2addda1f0d0f700d103d2e9e20b16711… commit 2addda1f0d0f700d103d2e9e20b16711b0f5d55b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri May 20 21:59:55 2016 +0200 add DIUCS debug log constant Change-Id: Id347a3024fa495a1ab680db7320648d933a4018b http://cgit.osmocom.org/openbsc/commit/?id=179a8988fb80ba9d337ef4daf48ff2ee… commit 179a8988fb80ba9d337ef4daf48ff2ee39b153cf Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 15:16:45 2016 +0200 gsm0408_loc_upd_rej(): remove bts use (used only for debug log) Change-Id: I3ac38f4b701ad8308470573260fa91a4b04c2f18 http://cgit.osmocom.org/openbsc/commit/?id=b0fe197014dbe15121c72ed49c88caa5… commit b0fe197014dbe15121c72ed49c88caa5d652688d Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 15:05:43 2016 +0200 gsm_04_08, gsm_subscriber: decouple lac from bts The idea is to not have a direct pointer to a bts struct (into BSC land), but a LAC to resolve the BSC or RNC depending on the appropriate A or IuCS interface. subscr_update(): remove bts arg, add lac arg. Pass conn->lac to gsm48_generate_lai() instead of bts->location_area_code. Change-Id: I9f2b298a785bf4b2a1b3fcdd91b8256106b2d9de http://cgit.osmocom.org/openbsc/commit/?id=3a70ce513b86a1c6651c30ef3985e8ba… commit 3a70ce513b86a1c6651c30ef3985e8bac14b49e0 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 15:06:35 2016 +0200 subscr_update_expire_lu(): remove bts arg Change-Id: I26cafd9389aac65e53dc4280a1687c6b8bce3106 http://cgit.osmocom.org/openbsc/commit/?id=f96cbb176bdaefedd11157f0ff6c3e6d… commit f96cbb176bdaefedd11157f0ff6c3e6db420215a Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 15:03:18 2016 +0200 move t3212 to network level (periodic lu) Set the T3212 default value in struct gsm_network and take that value when creating a BTS. Adjust VTY accordingly. Change-Id: Ifb730f9d0106fe195adc30459a39290a07313b50 http://cgit.osmocom.org/openbsc/commit/?id=8a04e94f3c93c56844d35e211ac19672… commit 8a04e94f3c93c56844d35e211ac19672844b8ecc Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 15:11:50 2016 +0200 libmsc: iucs dev: disable large parts of the code Change-Id: I3ef6ca26150b6102a0fa22a88a60d9a442d640b4 http://cgit.osmocom.org/openbsc/commit/?id=b0758294356e2437499c76f49dce9494… commit b0758294356e2437499c76f49dce9494f7ec3e8e Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue May 10 12:50:31 2016 +0200 Prepare entry/exit point for MSC -> BSC and MSC -> RNC communication. Add msc_ifaces.[hc], a_iface.c, with a general msc_tx_dtap() to redirect to different interfaces depending on the actual subscriber connection. While iu_tx() is going to be functional fairly soon, the a_tx() is going to be just a dummy for some time (see comment). Add Iu specific fields in gsm_subscriber_connection: the UE connection pointer and an indicator for the Integrity Protection status on Iu (to be fully implemented in later commits). Add lac member to gsm_subscriber_connection, to allow decoupling from bts->location_area_code. The conn->lac will actually be set in iu.c in an upcoming commit ("add iucs.[hc]"). Change-Id: Idf8020a30562426e8f939706bf5c2188d5a09798 http://cgit.osmocom.org/openbsc/commit/?id=1ccd42b652a22bc84cc6f98c8a3fc630… commit 1ccd42b652a22bc84cc6f98c8a3fc6305a56d418 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon May 30 15:13:32 2016 +0200 don't use lchan in libmsc Change-Id: Ic7ed7faa2bcc7aae799f41ed4abc2c001bfb61b7 http://cgit.osmocom.org/openbsc/commit/?id=4ca12a6571117d631fdfcffac4d45f29… commit 4ca12a6571117d631fdfcffac4d45f29adb527cf Author: Harald Welte <laforge(a)gnumonks.org> Date: Thu Dec 24 17:06:42 2015 +0100 gsm_04_08.c: Don't set msg->lchan nor msg->dst the BSC-side of the API behind gsm0808_submit_dtap() is doing this resolving again anyway. So let's avoid doing it twice, and avoid having more dependency of the MSC down into the lchan details. Conflicts: openbsc/src/libmsc/gsm_04_08.c Change-Id: I14254be68ee1a48e9f1ce968233414d86c6ba9d5 http://cgit.osmocom.org/openbsc/commit/?id=ffe71752448cc48fd27ba68628219dd2… commit ffe71752448cc48fd27ba68628219dd2eeb78cfa Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Feb 27 16:51:43 2017 +0100 conn timeout: implement conn_fsm COMMUNICATING state When in the ACCEPTED state, if the MS never sent any message, the conn would stay open indefinitely. Introduce a new state COMMUNICATING, so that the ACCEPTED state can timeout. COMMUNICATING starts as soon as the MS first replies with a message for CC, SMS or USSD negotiation. The CC/SMS/USSD code is then expected to handle timeouts and BUMP the conn_fsm as appropriate. Add new test in msc_vlr_test_ms_timeout.c to verify that a CM Service Request and Paging Response without replies from the MS time out. Explicitly test for the COMMUNICATING state in msc_vlr_test_no_authen.c, but in the other tests just rely on the test output validation to ensure that the new state is entered in the right places. Change-Id: If7c9acab9ed393874f21231a0f78464c384b3d2f http://cgit.osmocom.org/openbsc/commit/?id=b509e276194b9bb051bbac3ce0745d07… commit b509e276194b9bb051bbac3ce0745d071d4efcc6 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Feb 27 18:24:48 2017 +0100 fix segfault: when a conn is closed, clean up its trans From conn_fsm timeouts, it is possible that a subscriber connection gets discarded even though e.g. an SMS gsm_trans is still in the queue. Clean up all pending trans when the conn is closed, to prevent segfaults. Change-Id: I17a68c8c7e8faa44f9d19029a8f82bc7936c4d52 http://cgit.osmocom.org/openbsc/commit/?id=e52c5d0a109bc8bdaad9dfe6f6bb69be… commit e52c5d0a109bc8bdaad9dfe6f6bb69bef5668ea0 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Feb 22 02:27:59 2017 +0100 SI3: indicate R99+ MSC to GSM MS to enable UMTS AKA Change-Id: Iaf11218327f139e8cabfbc5f9916505c66eadbd8 http://cgit.osmocom.org/openbsc/commit/?id=6137844171d495ecd569846f8b4793fc… commit 6137844171d495ecd569846f8b4793fc5be76f1b Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Feb 15 00:20:44 2017 +0100 vlr: get SMS working, by SMS recipient MSISDN round-robin The SQL based lookup of SMS for attached subscribers no longer works since the SQL database no longer has the subscriber data. Replace with a round-robin on the SMS recipient MSISDNs paired with a VLR subscriber RAM lookup whether the subscriber is currently attached. If there are many SMS for not-attached subscribers in the SMS database, this will become inefficient: a DB hit returns a pending SMS, the RAM lookup will reveal that the subscriber is not attached, after which the DB is hit for the next SMS. It would become more efficient e.g. by having an MSISDN based hash list for the VLR subscribers and by marking non-attached SMS recipients in the SMS database so that they can be excluded with the SQL query already. There is a sanity limit to do at most 100 db hits per attempt to find a pending SMS. So if there are more than 100 stored SMS waiting for their recipients to actually attach to the MSC, it may take more than one SMS queue trigger to deliver SMS for subscribers that are actually attached. This is not very beautiful, but is merely intended to carry us over to a time when we have a proper separate SMSC entity. Change-Id: I1acf9debb6ba9164e6edcfd5bc5e48e8c98f2b01 http://cgit.osmocom.org/openbsc/commit/?id=628e7164d3ec440dfc5630c693cbc4a4… commit 628e7164d3ec440dfc5630c693cbc4a44c58806c Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 14 17:42:25 2017 +0100 logging: auth request: use hexdump without spaces for RAND, AUTN Change-Id: I656d8619a1adc93e2f627f4e1ba21512a7374279 http://cgit.osmocom.org/openbsc/commit/?id=43e8497da24b91e5ea5fea04bee155aa… commit 43e8497da24b91e5ea5fea04bee155aa813a170f Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Feb 12 00:34:35 2017 +0100 msc_vlr tests: add tests to reject concurrenct conns Change-Id: I5c04b1cf0ad302c35968e0f8dfb122997f3f7bf1 http://cgit.osmocom.org/openbsc/commit/?id=b45d8894250358f510f91f7f58b7b29e… commit b45d8894250358f510f91f7f58b7b29ef2ac2ab7 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Jan 25 15:04:16 2017 +0100 Add msc_vlr test suite for MSC+VLR end-to-end tests Change-Id: Ic073f3a069a7f5e7e421e0e56140f069ee9b10b8 http://cgit.osmocom.org/openbsc/commit/?id=c3e0e6165f62322e53df4384ed27f4ae… commit c3e0e6165f62322e53df4384ed27f4aeef64da38 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Feb 3 02:42:47 2017 +0100 Use libvlr in libmsc (large refactoring) Original libvlr code is by Harald Welte <laforge(a)gnumonks.org>rg>, polished and tweaked by Neels Hofmeyr <nhofmeyr(a)sysmocom.de>de>. This is a long series of development collapsed in one patch. The original history may still be available as branch neels/vlr_orig. TODO: This commit may be split in several smaller changes before merging to master. Related: OS#1592 Change-Id: I702ba504ce2de93507312c28eca8d11f09f4ee8b http://cgit.osmocom.org/openbsc/commit/?id=b3eebe95dcee84c0d437ba9e1a21c2de… commit b3eebe95dcee84c0d437ba9e1a21c2de58e4a002 Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Jun 17 00:06:42 2016 +0200 Add libvlr implementation Original libvlr code is by Harald Welte <laforge(a)gnumonks.org>rg>, polished and tweaked by Neels Hofmeyr <nhofmeyr(a)sysmocom.de>de>. This is a long series of development collapsed in one patch. The original history may still be available as branch neels/vlr_orig. Related: OS#1592 Change-Id: I3f75de5f0cc2ff77f276fd39832dd3621309c4b9 http://cgit.osmocom.org/openbsc/commit/?id=488b6dc581d3b8cb02bfe418dcd8e72b… commit 488b6dc581d3b8cb02bfe418dcd8e72b7b16a859 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Jun 19 18:06:02 2016 +0200 Introduce subscriber_connection ref-counting This introduces a reference count for gsm_subscriber_connection. Every user of the connection needs to hold a reference until done. Once the reference count dorps to zero, the connection is cleared towards the BSC (which subsequently will clear any logical channels associated with it). Related: OS#1592 Change-Id: I8c05e6c81f246ff8b5bf91312f80410b1a85f15e http://cgit.osmocom.org/openbsc/commit/?id=71baa3e2ddad4ecbe85b6471f8e9039a… commit 71baa3e2ddad4ecbe85b6471f8e9039aa91d6ebe Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Feb 18 22:20:46 2017 +0100 add struct bsc_subscr, separating libbsc from gsm_subscriber In a future commit, gsm_subscriber will be replaced by vlr_subscr, and it will not make sense to use vlr_subscr in libbsc. Thus we need a dedicated BSC subscriber: struct bsc_subscr. Add rf_policy arg to bsc_grace_paging_request() because the bsc_subscr will no longer have a backpointer to gsm_network (used to be via subscr->group). Create a separate logging filter for the new BSC subscriber. The implementation of adjusting the filter context is added in libbsc to not introduce bsc_subscr_get/_put() dependencies to libcommon. During Paging Response, fetch a bsc_subscr from the mobile identity, like we do for the gsm_subscriber. It looks like a duplication now, but will make sense for the VLR as well as for future MSC split patches. Naming: it was requested to not name the new struct bsc_sub, because 'sub' is too ambiguous. At the same time it would be fine to have 'bsc_sub_' as function prefix. Instead of struct bsc_subscriber and bsc_sub_ prefix, I decided to match both up as struct bsc_subscr and bsc_subscr_ function prefix. It's fast to type, relatively short, unambiguous, and the naming is consistent. Add bsc_subscr unit test. Related: OS#1592, OS#1594 Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e http://cgit.osmocom.org/openbsc/commit/?id=8be6fc4df2e63aedaae5c5a00be5a419… commit 8be6fc4df2e63aedaae5c5a00be5a419f48606c9 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Feb 2 01:07:28 2017 +0100 subscriber conn: add indicator for originating RAN Add via_ran to gsm_subscriber_connection to indicate whether a conn is coming in via 2G/GERAN/A-Interface or 3G/UTRAN/Iu-Interface. Prepares for Iu, but also for libvlr to decide between GSM or UMTS Auth. Until actual Iu support is merged to master, this indicator will aid VLR unit testing. At some point we may also add RAN_GERAN_IU; it's not on the agenda yet, but to clearly distinguish the names if we want to add it, explicitly name the ones we have RAN_GERAN_A and RAN_UTRAN_IU. Change-Id: I93b870522f725170e4265a5543f6b680383d7465 ----------------------------------------------------------------------- hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)