27 Sep
2017
27 Sep
'17
4:04 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".
The branch, master has been updated
via f4f23bd6829f78741cfd586f0ca9a290f221242e (commit)
via 607275c30be14266c4f1724b29a7cddea2062802 (commit)
from 6f4176785f4082ce0b3a80f860bcc0d40e9f49e9 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=f4f23bd6829f78741cfd586f0ca9…
commit f4f23bd6829f78741cfd586f0ca9a290f221242e
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Wed Sep 20 15:39:37 2017 +0200
vty: install 'exit', 'end',... commands on *all* nodes
In many callers of the VTY API, we are lacking the vty_install_default() step
at certain node levels. This creates nodes that lack the 'exit' command, and
hence the only way to exit such a node is to restart the telnet session.
Historically, the VTY looked for missing commands on the immediate parent node,
and hence possibly found the parent's 'exit' command when the local node
was
missing it. That is why we so far did not notice the missing default commands.
Furthermore, some callers call install_default() instead of
vty_install_default(). Only vty_install_default() also includes the 'exit'
and
'end' commands. There is no reason why there are two sets of default
commands.
To end this confusion, to catch all missing 'exit' commands and to prevent
this
from re-appearing in the future, simply *always* install all default commands
implicitly when calling install_node().
In cmd_init(), there are some top-level nodes that apparently do not want the
default commands installed. Keep those the way they are, by changing the
invocation to new install_node_bare() ({VIEW,AUTH,AUTH_ENABLE}_NODE).
Make both install_default() and vty_install_default() no-ops so that users of
the API may still call them without harm. Do not yet deprecate yet, which
follows in Icf5d83f641e838cebcccc635a043e94ba352abff.
Drop all invocations to these two functions found in libosmocore.
Change-Id: I5021c64a787b63314e0f2f1cba0b8fc7bff4f09b
http://cgit.osmocom.org/libosmocore/commit/?id=607275c30be14266c4f1724b29a7…
commit 607275c30be14266c4f1724b29a7cddea2062802
Author: Neels Hofmeyr <neels(a)hofmeyr.de>
Date: Mon Sep 25 00:35:06 2017 +0200
gb: drop special vty exit commands, use vty_install_default()
L_NS_NODE and L_BSSGP_NODE had specialized 'exit' and 'end' vty
commands, but
all they do is return to the CONFIG and ENABLE_NODEs like the default 'exit'
and 'end' commands. Drop them and use the default 'exit' and
'end' cmds.
Examining BSSGP and NS node behavior in osmo-sgsn exhibited identical list and
exit/end behavior before and after this patch.
Prepares for an upcoming commit incorporating vty_install_default() into
install_node(), see I5021c64a787b63314e0f2f1cba0b8fc7bff4f09b: this patch
changes to the default commands, the upcoming change implies them.
Change-Id: I5b0de066b4249d482c22620d5b1bcb03f381293c
-----------------------------------------------------------------------
Summary of changes:
include/osmocom/vty/command.h | 5 ++---
src/ctrl/control_vty.c | 1 -
src/gb/common_vty.c | 34 ----------------------------------
src/gb/common_vty.h | 3 ---
src/gb/gprs_bssgp_vty.c | 3 ---
src/gb/gprs_ns_vty.c | 3 ---
src/vty/command.c | 42 +++++++++++++++++++++++++++++-------------
src/vty/logging_vty.c | 1 -
src/vty/stats_vty.c | 1 -
src/vty/vty.c | 1 -
tests/vty/vty_test.c | 3 ---
11 files changed, 31 insertions(+), 66 deletions(-)
hooks/post-receive
--
An utility library for Open Source Mobile Communications