openbsc.git branch neels/vlr updated. 0.15.0-714-g4bb7cdbbc

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, neels/vlr has been updated discards a7b710f0c0e335c3499a912dae21b42b05101e6c (commit) discards b01d330fadbb350ca099ee03d6b8f882e0b72764 (commit) discards 45d42cb73d1f3f28013da759fcc70bc1164e536b (commit) discards f82934cbde4268f354c3a3fbccc92e5f0152cf2a (commit) discards aca038e29f11910b3e86ace331a62c7effd49c04 (commit) discards 7e04de1a9957eea5829a8a3a23543a86795d5dab (commit) discards 5b7fb9afe65a67bf370511fdaa205889b078c6d9 (commit) discards 6bc9baada400146bb07fec5481660179b3f4b712 (commit) discards 10f504a7cf5a88ac54705e933645478c6d855508 (commit) discards 37e9b08513e79becee49352aa23d98ba61db0605 (commit) discards cc7474beb8ef17a8e9988a2cb8f132fc45133476 (commit) discards fd5a900ee3c56685c566b0051ff94f457830003e (commit) discards 2afa7995eb0460cffffe2a8e7f7f2dd5f33e3c3a (commit) via 4bb7cdbbca685f987495a76715afff9663e41890 (commit) via d56bc3cfa6e647cedd1926e59a22c1e3b349280a (commit) via 922aa2a5408e6df2ea15fca40a7b7b5882e734a1 (commit) via 1554868d6582af568aa7a43cae503fb9f0943a05 (commit) via ed2dfb9c383bac89bd1aedad3fda32c017e98eae (commit) via eba7bf58ecacc8fee288c7a55c428dee3bb50dea (commit) via d433f1896facd6fe960b24c8eb5e4ec3ab8f87e3 (commit) via cf79a5020a4bfc414a75bc08988218a4c8b79589 (commit) via b98480a1df158ee55ccd41edda52af171c68686a (commit) via a5113842492adc11c09fe2c2eb63fd2768342e61 (commit) via 56917719d45cfcf4d23500bee8af6a22fce5a688 (commit) via 33db85f41c61077df2d57c682613fffe7f7cfc08 (commit) via b210eec919b7c5323f316cbed87c34b53a9c2e35 (commit) via 088b9275e500cb81f39f35cbe7d36a40508e8862 (commit) via 9ef4693c695c4ba774b09b8553db036c674d4183 (commit) via f1b73979a1d11cac1679d6b7e7525452e1b44667 (commit) via 596c6890fb8c4fa3fc4a16c819056eee8e39cea7 (commit) via 21af9edfa56ef68cd22b7d8f7a57ea931f609df4 (commit) via 27355c9c654e7035d8fea0619f3832e978a244bb (commit) via 058cd573d8c5554eba31cd4cc31625630ceeca1a (commit) via 44468ad531b7baa1c5692d224b2f11695af47970 (commit) via 577a1256525a2177f6dee10857b245c09d1e9d82 (commit) via 8b24e9f2035c36abe1310a3b5bbe212b10fe4d08 (commit) via c634063ea37875f38a31c5ff643a5fed43d7cafa (commit) via 0e5d807297f4fd1222fafece864519c70f7965a3 (commit) via a369e24cb9a583ef9906a8ef9125f6ca8c6f80bf (commit) via a42855f09fc74bdc801fdd7adfef27e2cdf3f371 (commit) via 9762b4c5794edba56b2976fcae5097e514a4b080 (commit) via fe291de36b8cf80818dc97b4ad4d790fc01e96ec (commit) via d2b3399c047c601f6c08ae33368f2020dfb9f935 (commit) via 40a91b38ec6c9778fed18376e559631c5abe6c1a (commit) via 7a250cc9d9e4bf493d8f92d348fac16976ce6521 (commit) via 89a8e722ed57618a64a7cc0b0c644ed8d4d11da5 (commit) This update added new revisions after undoing existing revisions. That is to say, the old revision is not a strict subset of the new revision. This situation occurs when you --force push a change and generate a repository containing something like this: * -- * -- B -- O -- O -- O (a7b710f0c0e335c3499a912dae21b42b05101e6c) \ N -- N -- N (4bb7cdbbca685f987495a76715afff9663e41890) When this happens we assume that you've already had alert emails for all of the O revisions, and so we here report only the revisions in the N branch from the common base, B. Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=4bb7cdbbca685f987495a76715afff96… commit 4bb7cdbbca685f987495a76715afff9663e41890 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Feb 27 16:51:43 2017 +0100 conn timeout: implement conn_fsm COMMUNICATING state When in the ACCEPTED state, if the MS never sent any message, the conn would stay open indefinitely. Introduce a new state COMMUNICATING, so that the ACCEPTED state can timeout. COMMUNICATING starts as soon as the MS first replies with a message for CC, SMS or USSD negotiation. The CC/SMS/USSD code is then expected to handle timeouts and BUMP the conn_fsm as appropriate. Add new test in msc_vlr_test_ms_timeout.c to verify that a CM Service Request and Paging Response without replies from the MS time out. Explicitly test for the COMMUNICATING state in msc_vlr_test_no_authen.c, but in the other tests just rely on the test output validation to ensure that the new state is entered in the right places. Change-Id: If7c9acab9ed393874f21231a0f78464c384b3d2f http://cgit.osmocom.org/openbsc/commit/?id=d56bc3cfa6e647cedd1926e59a22c1e3… commit d56bc3cfa6e647cedd1926e59a22c1e3b349280a Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Feb 27 18:24:48 2017 +0100 fix segfault: when a conn is closed, clean up its trans From conn_fsm timeouts, it is possible that a subscriber connection gets discarded even though e.g. an SMS gsm_trans is still in the queue. Clean up all pending trans when the conn is closed, to prevent segfaults. Change-Id: I17a68c8c7e8faa44f9d19029a8f82bc7936c4d52 http://cgit.osmocom.org/openbsc/commit/?id=922aa2a5408e6df2ea15fca40a7b7b58… commit 922aa2a5408e6df2ea15fca40a7b7b5882e734a1 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Feb 22 02:27:59 2017 +0100 SI3: indicate R99+ MSC to GSM MS to enable UMTS AKA Change-Id: Iaf11218327f139e8cabfbc5f9916505c66eadbd8 http://cgit.osmocom.org/openbsc/commit/?id=1554868d6582af568aa7a43cae503fb9… commit 1554868d6582af568aa7a43cae503fb9f0943a05 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Feb 15 00:20:44 2017 +0100 vlr: get SMS working, by SMS recipient MSISDN round-robin The SQL based lookup of SMS for attached subscribers no longer works since the SQL database no longer has the subscriber data. Replace with a round-robin on the SMS recipient MSISDNs paired with a VLR subscriber RAM lookup whether the subscriber is currently attached. If there are many SMS for not-attached subscribers in the SMS database, this will become inefficient: a DB hit returns a pending SMS, the RAM lookup will reveal that the subscriber is not attached, after which the DB is hit for the next SMS. It would become more efficient e.g. by having an MSISDN based hash list for the VLR subscribers and by marking non-attached SMS recipients in the SMS database so that they can be excluded with the SQL query already. There is a sanity limit to do at most 100 db hits per attempt to find a pending SMS. So if there are more than 100 stored SMS waiting for their recipients to actually attach to the MSC, it may take more than one SMS queue trigger to deliver SMS for subscribers that are actually attached. This is not very beautiful, but is merely intended to carry us over to a time when we have a proper separate SMSC entity. Change-Id: I1acf9debb6ba9164e6edcfd5bc5e48e8c98f2b01 http://cgit.osmocom.org/openbsc/commit/?id=ed2dfb9c383bac89bd1aedad3fda32c0… commit ed2dfb9c383bac89bd1aedad3fda32c017e98eae Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 14 17:42:25 2017 +0100 logging: auth request: use hexdump without spaces for RAND, AUTN Change-Id: I656d8619a1adc93e2f627f4e1ba21512a7374279 http://cgit.osmocom.org/openbsc/commit/?id=eba7bf58ecacc8fee288c7a55c428dee… commit eba7bf58ecacc8fee288c7a55c428dee3bb50dea Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sun Feb 12 00:34:35 2017 +0100 msc_vlr tests: add tests to reject concurrenct conns Change-Id: I5c04b1cf0ad302c35968e0f8dfb122997f3f7bf1 http://cgit.osmocom.org/openbsc/commit/?id=d433f1896facd6fe960b24c8eb5e4ec3… commit d433f1896facd6fe960b24c8eb5e4ec3ab8f87e3 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Wed Jan 25 15:04:16 2017 +0100 Add msc_vlr test suite for MSC+VLR end-to-end tests Change-Id: Ic073f3a069a7f5e7e421e0e56140f069ee9b10b8 http://cgit.osmocom.org/openbsc/commit/?id=cf79a5020a4bfc414a75bc08988218a4… commit cf79a5020a4bfc414a75bc08988218a4c8b79589 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Feb 3 02:42:47 2017 +0100 Use libvlr in libmsc (large refactoring) Original libvlr code is by Harald Welte <laforge(a)gnumonks.org>rg>, polished and tweaked by Neels Hofmeyr <nhofmeyr(a)sysmocom.de>de>. This is a long series of development collapsed in one patch. The original history may still be available as branch neels/vlr_orig. TODO: This commit may be split in several smaller changes before merging to master. Related: OS#1592 Change-Id: I702ba504ce2de93507312c28eca8d11f09f4ee8b http://cgit.osmocom.org/openbsc/commit/?id=b98480a1df158ee55ccd41edda52af17… commit b98480a1df158ee55ccd41edda52af171c68686a Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Jun 17 00:06:42 2016 +0200 Add libvlr implementation Original libvlr code is by Harald Welte <laforge(a)gnumonks.org>rg>, polished and tweaked by Neels Hofmeyr <nhofmeyr(a)sysmocom.de>de>. This is a long series of development collapsed in one patch. The original history may still be available as branch neels/vlr_orig. Related: OS#1592 Change-Id: I3f75de5f0cc2ff77f276fd39832dd3621309c4b9 http://cgit.osmocom.org/openbsc/commit/?id=a5113842492adc11c09fe2c2eb63fd27… commit a5113842492adc11c09fe2c2eb63fd2768342e61 Author: Harald Welte <laforge(a)gnumonks.org> Date: Sun Jun 19 18:06:02 2016 +0200 Introduce subscriber_connection ref-counting This introduces a reference count for gsm_subscriber_connection. Every user of the connection needs to hold a reference until done. Once the reference count dorps to zero, the connection is cleared towards the BSC (which subsequently will clear any logical channels associated with it). Related: OS#1592 Change-Id: I8c05e6c81f246ff8b5bf91312f80410b1a85f15e http://cgit.osmocom.org/openbsc/commit/?id=56917719d45cfcf4d23500bee8af6a22… commit 56917719d45cfcf4d23500bee8af6a22fce5a688 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Thu Feb 2 01:07:28 2017 +0100 subscriber conn: add indicator for originating interface Add via_iface to gsm_subscriber_connection to indicate whether a conn is coming in via 2G/GERAN/A-Interface (IFACE_A) or 3G/UTRAN/Iu-Interface (IFACE_IU). Prepares for Iu, but also for libvlr to decide between GSM or UMTS Auth. Until actual Iu support is merged to master, this indicator will aid VLR unit testing. Change-Id: I93b870522f725170e4265a5543f6b680383d7465 http://cgit.osmocom.org/openbsc/commit/?id=33db85f41c61077df2d57c682613fffe… commit 33db85f41c61077df2d57c682613fffe7f7cfc08 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Sat Feb 18 22:20:46 2017 +0100 add struct bsc_subscr, separating libbsc from gsm_subscriber In a future commit, gsm_subscriber will be replaced by vlr_subscr, and it will not make sense to use vlr_subscr in libbsc. Thus we need a dedicated BSC subscriber: struct bsc_subscr. Add rf_policy arg to bsc_grace_paging_request() because the bsc_subscr will no longer have a backpointer to gsm_network (used to be via subscr->group). Create a separate logging filter for the new BSC subscriber. The implementation of adjusting the filter context is added in libbsc to not introduce bsc_subscr_get/_put() dependencies to libcommon. During Paging Response, fetch a bsc_subscr from the mobile identity, like we do for the gsm_subscriber. It looks like a duplication now, but will make sense for the VLR as well as for future MSC split patches. Naming: it was requested to not name the new struct bsc_sub, because 'sub' is too ambiguous. At the same time it would be fine to have 'bsc_sub_' as function prefix. Instead of struct bsc_subscriber and bsc_sub_ prefix, I decided to match both up as struct bsc_subscr and bsc_subscr_ function prefix. It's fast to type, relatively short, unambiguous, and the naming is consistent. Add bsc_subscr unit test. Related: OS#1592, OS#1594 Change-Id: Ia61cc00e8bb186b976939a4fc8f7cf9ce6aa3d8e http://cgit.osmocom.org/openbsc/commit/?id=b210eec919b7c5323f316cbed87c34b5… commit b210eec919b7c5323f316cbed87c34b53a9c2e35 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 28 02:37:39 2017 +0100 vty tests: close msc socket after nat_msc_test Change-Id: Ib64cf8690627803e1b4a8497ea63f1e766960478 http://cgit.osmocom.org/openbsc/commit/?id=088b9275e500cb81f39f35cbe7d36a40… commit 088b9275e500cb81f39f35cbe7d36a40508e8862 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 28 02:43:29 2017 +0100 vty tests: allow picking specific tests to run by name Change-Id: I849455e0423e1a63d6890aef7f9c6075ad53a920 http://cgit.osmocom.org/openbsc/commit/?id=9ef4693c695c4ba774b09b8553db036c… commit 9ef4693c695c4ba774b09b8553db036c674d4183 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Fri Feb 24 17:55:11 2017 +0100 python tests: allow running from separate build dir The VTY tests assume that $top_builddir == $top_srcdir. Use the script's location from sys.path[0] to find the correct locations of example configs even when building in another directory. Change-Id: I2731f361e3b72d0980968e6cf83594ea450db7c2 http://cgit.osmocom.org/openbsc/commit/?id=f1b73979a1d11cac1679d6b7e7525452… commit f1b73979a1d11cac1679d6b7e7525452e1b44667 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Tue Feb 28 02:38:43 2017 +0100 vty test: nat_msc_test: setsockopt REUSE to avoid TIME_WAIT problems When running the testBSCreload test in close succession, I get a "Connection refused" error because the socket is still in TIME_WAIT state. Passing the SO_REUSEADDR flag allows reusing the addr despite a TIME_WAIT socket. Change-Id: I941851b062999ab4b962430f7b27c19935993e0a http://cgit.osmocom.org/openbsc/commit/?id=596c6890fb8c4fa3fc4a16c819056eee… commit 596c6890fb8c4fa3fc4a16c819056eee8e39cea7 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Feb 27 02:05:42 2017 +0100 python tests: vty and smpp: speed up >10 times osmo-python-tests now includes code that retries connecting the VTY socket and needs no external sleep()ing. This flies through most tests without any sleep() at all. See osmo-python-tests.git change-id Icc337f52a93d5fe31fc4ff235ccaf4e0fe75fa39 Change-Id: I42161d9716fe5bb0ef1c56e4bfb770bb99bbca7a http://cgit.osmocom.org/openbsc/commit/?id=21af9edfa56ef68cd22b7d8f7a57ea93… commit 21af9edfa56ef68cd22b7d8f7a57ea931f609df4 Author: Neels Hofmeyr <nhofmeyr(a)sysmocom.de> Date: Mon Feb 27 02:01:37 2017 +0100 XXX ctrl_test_runner: speed up more than 10 fold by sleeping less Similar to a recent patch in osmo-python-tests for VTY based tests, but this is for the Ctrl tests. The TestCtrlBase tests gave a constant sleep(2) grace period for the process to startup. This causes tests to take minutes for no reason at all. Add code to TestCtrlBase to try and connect right away, retrying up to three seconds in .1 second intervals. This flies through most tests without any sleep() at all. Change-Id: I06569767153838bd9cd3edac001df5f6c567874c ----------------------------------------------------------------------- Summary of changes: openbsc/README | 2 +- openbsc/include/openbsc/Makefile.am | 2 +- .../openbsc/{osmo_msc_data.h => bsc_msc_data.h} | 14 +- openbsc/include/openbsc/bsc_subscriber.h | 8 +- openbsc/include/openbsc/gprs_sgsn.h | 1 + openbsc/include/openbsc/gsm_data.h | 2 +- openbsc/include/openbsc/osmo_bsc.h | 10 +- openbsc/include/openbsc/osmo_bsc_grace.h | 4 +- openbsc/include/openbsc/osmo_msc.h | 4 + openbsc/include/openbsc/signal.h | 4 +- openbsc/include/openbsc/transaction.h | 1 + openbsc/src/gprs/gprs_gmm.c | 89 +- openbsc/src/gprs/sgsn_auth.c | 1 + openbsc/src/gprs/sgsn_main.c | 2 +- openbsc/src/gprs/sgsn_vty.c | 20 +- openbsc/src/libbsc/abis_rsl.c | 2 +- openbsc/src/libbsc/bsc_ctrl_commands.c | 2 +- openbsc/src/libbsc/bsc_init.c | 3 +- openbsc/src/libbsc/bsc_rf_ctrl.c | 2 +- openbsc/src/libbsc/bsc_subscriber.c | 14 +- openbsc/src/libbsc/bsc_vty.c | 2 +- openbsc/src/libbsc/net_init.c | 2 +- openbsc/src/libbsc/paging.c | 9 +- openbsc/src/libcommon/debug.c | 24 +- openbsc/src/libcommon/gsm_data.c | 2 +- openbsc/src/libmsc/gsm_04_08.c | 18 +- openbsc/src/libmsc/gsm_04_11.c | 2 + openbsc/src/libmsc/gsm_subscriber.c | 2 +- openbsc/src/libmsc/osmo_msc.c | 3 +- openbsc/src/libmsc/smpp_openbsc.c | 2 +- openbsc/src/libmsc/subscr_conn.c | 70 +- openbsc/src/libmsc/transaction.c | 10 + openbsc/src/libmsc/ussd.c | 1 + openbsc/src/libmsc/vty_interface_layer3.c | 31 +- openbsc/src/libvlr/vlr.c | 6 +- openbsc/src/libvlr/vlr_access_req_fsm.c | 1 + openbsc/src/osmo-bsc/osmo_bsc_api.c | 24 +- openbsc/src/osmo-bsc/osmo_bsc_audio.c | 2 +- openbsc/src/osmo-bsc/osmo_bsc_bssap.c | 16 +- openbsc/src/osmo-bsc/osmo_bsc_ctrl.c | 10 +- openbsc/src/osmo-bsc/osmo_bsc_filter.c | 10 +- openbsc/src/osmo-bsc/osmo_bsc_grace.c | 8 +- openbsc/src/osmo-bsc/osmo_bsc_main.c | 6 +- openbsc/src/osmo-bsc/osmo_bsc_msc.c | 56 +- openbsc/src/osmo-bsc/osmo_bsc_sccp.c | 6 +- openbsc/src/osmo-bsc/osmo_bsc_vty.c | 70 +- openbsc/src/osmo-nitb/bsc_hack.c | 2 +- openbsc/src/utils/Makefile.am | 17 + openbsc/src/utils/meas_json.c | 189 ++++ openbsc/tests/bsc/bsc_test.c | 6 +- openbsc/tests/ctrl_test_runner.py | 20 +- openbsc/tests/msc_vlr/msc_vlr_test_gsm_authen.err | 45 +- openbsc/tests/msc_vlr/msc_vlr_test_gsm_ciph.err | 30 +- openbsc/tests/msc_vlr/msc_vlr_test_hlr_timeout.err | 4 +- openbsc/tests/msc_vlr/msc_vlr_test_ms_timeout.c | 472 ++++++++++ openbsc/tests/msc_vlr/msc_vlr_test_ms_timeout.err | 987 ++++++++++++++++++++- openbsc/tests/msc_vlr/msc_vlr_test_no_authen.c | 3 + openbsc/tests/msc_vlr/msc_vlr_test_no_authen.err | 33 +- .../msc_vlr/msc_vlr_test_reject_concurrency.err | 33 +- openbsc/tests/msc_vlr/msc_vlr_test_umts_authen.err | 30 +- openbsc/tests/msc_vlr/msc_vlr_tests.c | 13 +- openbsc/tests/msc_vlr/msc_vlr_tests.h | 22 +- openbsc/tests/sgsn/sgsn_test.c | 1 + openbsc/tests/smpp_test_runner.py | 7 +- openbsc/tests/subscr/bsc_subscr_test.c | 6 +- openbsc/tests/vty_test_runner.py | 239 ++--- 66 files changed, 2230 insertions(+), 509 deletions(-) rename openbsc/include/openbsc/{osmo_msc_data.h => bsc_msc_data.h} (89%) create mode 100644 openbsc/src/utils/meas_json.c hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)