21 Jan
2015
21 Jan
'15
4:57 p.m.
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, master has been updated
via 9d1a17e15f6902bc9591680da3375b2d14db16ab (commit)
from b194862b62ffd808c91011f37f2412ebd3cb7378 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=9d1a17e15f6902bc9591680da3375b2d…
commit 9d1a17e15f6902bc9591680da3375b2d14db16ab
Author: Holger Hans Peter Freyther <holger(a)moiji-mobile.com>
Date: Wed Jan 21 16:53:53 2015 +0100
osmux: Initialize the socket only once
The per BSC code didn't guard against the init already having
been executed. This lead to:
Adding a osmo_fd that is already in the list.
<000b> bsc_nat_vty.c:1200 Setting up OSMUX socket
So a new socket got created and the old one leaked. Luckily
Linux appears to allow to bind multiple times so we were able
to just read from the new one. Use the same guard that is used
on the MGCP MGW. Re-order the log message to say "Setting up"
before we actually do that. I manually verified that osmux_init
is called at most once.
The log message was spotted by Roch
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/osmo-bsc_nat/bsc_nat_vty.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)