By random, I looked at an fd leak complained about by coverity in osmo_stream_srv_fd_cb() and came up with https://gerrit.osmocom.org/1320 Now I wanted to at least run it once to make sure I didn't break anything, but I'm unsure in figuring out how it is used. There are two Iu related callers: osmo-iuh's hnbgw.c and libosmo-sccp's sua.c. And I find libosmo-netif/src/channel/abis/ipa_stream_server.c, called in libosmo-netif/src/channel.c by osmo_chan_init() and osmo_chan_create(). But it seems no-one is ever calling these, except for examples in libosmo-netif. Am I right to conclude that there's some 2G / Abis / ip.access related code in libosmo-netif but we're not actually using it in openbsc, and that the only "real" osmo_stream_srv_* callers are 3G/Iu related? ~N -- - Neels Hofmeyr <nhofmeyr@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte
Hi Neels, On Mon, Nov 28, 2016 at 01:32:36PM +0100, Neels Hofmeyr wrote:
Am I right to conclude that there's some 2G / Abis / ip.access related code in libosmo-netif but we're not actually using it in openbsc, and that the only "real" osmo_stream_srv_* callers are 3G/Iu related?
Yes, at least likely. The history is as follows: * we implemented openbsc with classic Abis over LAPD/E1 * we added IPA Abis/IP to it * that code went into libosmo-abis * Pablo was tasked with the OSMUX implementation for a more efficient transport protocol * Pablo wrote libosmo-netif as a sort of unification layer on top of IP and OSMUX * We started to use osmux in osmo-bsc (and bsc-nat?) for the A interface * We kept using libosmo-netif only for OSMUX but never migrated the other code over to it It might not be an exact historical record, but I guess you'd have to ask Pablo for more details -- - Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
participants (2)
-
Harald Welte -
Neels Hofmeyr