[PATCH] osmo-bts[master]: octphy: Update outdated config param name in error message.
Review at https://gerrit.osmocom.org/129 octphy: Update outdated config param name in error message. Change-Id: I45b8bc09c9aabacc5b908450fe574b5802b88be8 --- M src/osmo-bts-octphy/l1_if.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/29/129/1 diff --git a/src/osmo-bts-octphy/l1_if.c b/src/osmo-bts-octphy/l1_if.c index ec61d6b..c8ed216 100644 --- a/src/osmo-bts-octphy/l1_if.c +++ b/src/osmo-bts-octphy/l1_if.c @@ -1618,7 +1618,7 @@ fl1h->phy_link = plink; if (!phy_dev) { - LOGP(DL1C, LOGL_ERROR, "You have to specify a phy-netdev\n"); + LOGP(DL1C, LOGL_ERROR, "You have to specify a octphy net-device\n"); talloc_free(fl1h); return NULL; } -- To view, visit https://gerrit.osmocom.org/129 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I45b8bc09c9aabacc5b908450fe574b5802b88be8 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: lazlo <dlsitzer@gmail.com>
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/129 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45b8bc09c9aabacc5b908450fe574b5802b88be8 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: lazlo <dlsitzer@gmail.com> Gerrit-Reviewer: Holger Freyther <holger@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
Holger Freyther has submitted this change and it was merged. Change subject: octphy: Update outdated config param name in error message. ...................................................................... octphy: Update outdated config param name in error message. Change-Id: I45b8bc09c9aabacc5b908450fe574b5802b88be8 Reviewed-on: https://gerrit.osmocom.org/129 Tested-by: Jenkins Builder Reviewed-by: Holger Freyther <holger@freyther.de> --- M src/osmo-bts-octphy/l1_if.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Holger Freyther: Looks good to me, approved diff --git a/src/osmo-bts-octphy/l1_if.c b/src/osmo-bts-octphy/l1_if.c index ec61d6b..c8ed216 100644 --- a/src/osmo-bts-octphy/l1_if.c +++ b/src/osmo-bts-octphy/l1_if.c @@ -1618,7 +1618,7 @@ fl1h->phy_link = plink; if (!phy_dev) { - LOGP(DL1C, LOGL_ERROR, "You have to specify a phy-netdev\n"); + LOGP(DL1C, LOGL_ERROR, "You have to specify a octphy net-device\n"); talloc_free(fl1h); return NULL; } -- To view, visit https://gerrit.osmocom.org/129 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45b8bc09c9aabacc5b908450fe574b5802b88be8 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: lazlo <dlsitzer@gmail.com> Gerrit-Reviewer: Holger Freyther <holger@freyther.de> Gerrit-Reviewer: Jenkins Builder
Patch Set 2: (1 comment)
Change has been successfully cherry-picked as 0778cd488a6696772e2fda32ee9ab9889f439d62 by Holger Freyther
https://gerrit.osmocom.org/#/c/129/2/src/osmo-bts-octphy/l1_if.c File src/osmo-bts-octphy/l1_if.c: Line 1621: LOGP(DL1C, LOGL_ERROR, "You have to specify a octphy net-device\n"); Maybe it would be better to use the 'an' article instead of 'a'? -- To view, visit https://gerrit.osmocom.org/129 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45b8bc09c9aabacc5b908450fe574b5802b88be8 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: lazlo <dlsitzer@gmail.com> Gerrit-Reviewer: Holger Freyther <holger@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> Gerrit-HasComments: Yes
participants (3)
-
Holger Freyther -
lazlo -
Vadim Yanitskiy