Hi list, I'd like to gauge your opinions on how to handle reverts: On the one hand, it is good to keep the revert as an exact reverse of the original commit. On the other hand, it may be good to include an in-code comment in the revert to clarify the details for future readers. If both the revert and the comment happen in the same commit, 'git blame' nicely shows that they are related. I would tend towards keeping the revert "clean" and adding comments in a separate commit -- how would you handle this? Thanks, ~Neels -- - Neels Hofmeyr <nhofmeyr@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte
Hi Neels, On Thu, Aug 11, 2016 at 12:41:52PM +0200, Neels Hofmeyr wrote:
I would tend towards keeping the revert "clean" and adding comments in a separate commit -- how would you handle this?
I don't really care, no preference either way. -- - Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
participants (2)
-
Harald Welte -
Neels Hofmeyr