[PATCH 1/2] gsm0411_smr: Make the look-up table static
From: Holger Hans Peter Freyther <holger@moiji-mobile.com> --- src/gsm/gsm0411_smr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gsm/gsm0411_smr.c b/src/gsm/gsm0411_smr.c index b243c86..a7e9d24 100644 --- a/src/gsm/gsm0411_smr.c +++ b/src/gsm/gsm0411_smr.c @@ -94,7 +94,7 @@ void gsm411_smr_clear(struct gsm411_smr_inst *inst) osmo_timer_del(&inst->rp_timer); } -const char *smr_state_names[] = { +static const char *smr_state_names[] = { "IDLE", "WAIT_FOR_RP_ACK", "illegal state 2" -- 1.9.1
From: Holger Hans Peter Freyther <holger@moiji-mobile.com> The code is lacking a "," at the end of a string and we ended up doing string concatination instead of having an invalid state. Fixes Coverity CID 1206564 --- src/gsm/gsm0411_smr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gsm/gsm0411_smr.c b/src/gsm/gsm0411_smr.c index a7e9d24..eb1f036 100644 --- a/src/gsm/gsm0411_smr.c +++ b/src/gsm/gsm0411_smr.c @@ -97,7 +97,7 @@ void gsm411_smr_clear(struct gsm411_smr_inst *inst) static const char *smr_state_names[] = { "IDLE", "WAIT_FOR_RP_ACK", - "illegal state 2" + "illegal state 2", "WAIT_TO_TX_RP_ACK", "WAIT_FOR_RETRANS_T", }; -- 1.9.1
participants (1)
-
Holger Hans Peter Freyther