I would like to see https://gerrit.osmocom.org/#/c/1411/ fixed and merged. Firstly, the way the code is written leaves it unclear whether it works as intended. Secondly, this is blocking the effort to do more sanitizer builds in jenkins / gerrit build jobs. Aravind, would you please provide feedback on your availability -- will you get around to this any time soon, or should we try to assign this to someone else? Thanks! ~N -- - Neels Hofmeyr <nhofmeyr@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte
While this is ongoing we could enable sanitizer builds for all the libosmo* projects. The point which is unclear to me yet, should all the dependencies build with sanitizer enabled as well, or we can enable it on per-project basis independently? For example: libosmo-abis depends on libosmocore. Does it mean that we should build libosmocore with sanitizer enabled as well when building it as a dependency for libosmo-abis sanitizer build? On 10.01.2017 12:45, Neels Hofmeyr wrote:
Secondly, this is blocking the effort to do more sanitizer builds in jenkins / gerrit build jobs.
-- Max Suraev <msuraev@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte
On Tue, Jan 10, 2017 at 02:29:58PM +0100, Max wrote:
While this is ongoing we could enable sanitizer builds for all the libosmo* projects.
I'll gladly switch more builds to sanitizer when we have ./configure --enable-sanitize options, as I said before. Would (still) be nice to see some patches like https://gerrit.osmocom.org/#/c/974/ submitted for the other libraries. Thanks! ~N
FYI, Aravind replied off-list. I will move back to gerrit #1411 for further comments. ~N On Tue, Jan 10, 2017 at 12:45:16PM +0100, Neels Hofmeyr wrote:
I would like to see https://gerrit.osmocom.org/#/c/1411/ fixed and merged. [...]
-- - Neels Hofmeyr <nhofmeyr@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Harald Welte
participants (2)
-
Max -
Neels Hofmeyr