While at it you might also use rate_ctr instead of counter. This way I'll have more example for docs :) On 05/09/2016 12:40 PM, Neels Hofmeyr wrote:

Hi list,

I'm noticing an inaccuracy/ambiguity in the stat counters concerning Location Updating. So far we have:

struct gsmnet_stats {

struct { struct osmo_counter *reject; <-- inc when MM LU Reject is sent struct osmo_counter *accept; <-- inc when MM LU Accept is sent } loc_upd_resp; }

Looks good? Well, not entirely.

(1) When we use TMSIs, we first send a LU Accept with a new TMSI, and then expect the MS to respond with a TMSI Realloc Complete message. When that fails to come through, the LU actually ends in failure, even though a LU Accept was sent.

(2) In 3G, if a UE sends an Iu Release during LU (e.g. user enables flight mode), we cancel the LU without sending any reply at all, so nothing would be counted.

I would like to change the naming and inc hooks to reflect actual LU success or failure. We don't need to count the actual messages sent, right?

~Neels

-- Max Suraev <msuraev@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte