osmo-msc needs a fix of fsm names
Talking about libosmocore changes that break builds ;) By chance I noticed that since now osmo-gsm-tester tests fail for AoIP, osmo-msc bailing with fsm.c:150 Attempting to register FSM with illegal identifier 'FSM RESET' fsm.c:216 Attempting to allocate FSM instance of type 'FSM RESET' with illegal identifier 'FSM RESET INST' @pmaier, please fix osmo-msc's FSM name in a_reset.c ASAP. We can't test OsmoMSC until you do. Thanks! ~N
On Wed, Oct 25, 2017 at 01:32:51AM +0200, Neels Hofmeyr wrote:
fsm.c:150 Attempting to register FSM with illegal identifier 'FSM RESET' fsm.c:216 Attempting to allocate FSM instance of type 'FSM RESET' with illegal identifier 'FSM RESET INST'
forgot to point at https://osmocom.org/issues/2593 ~N
Hi Neels,
forgot to point at https://osmocom.org/issues/2593
I see, I have now abandonned the msc patch again. It should be fine now. However, jenkins seems to have some problems. Probably unrelated to this, but i am not sure. https://jenkins.osmocom.org/jenkins/job/osmo-bsc-gerrit/label=linux_amd64_de... regards, Philipp -- Philipp Maier <pmaier@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte
Hi Neels, I have removed the whitespace now. See the following patches: https://gerrit.osmocom.org/4408 https://gerrit.osmocom.org/4409 However, we have some code duplication here. Maybe we can move the reset into libosmo-sigtran or libosmocore? regards. Philipp -- Philipp Maier <pmaier@sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Director: Harald Welte
participants (2)
-
Neels Hofmeyr -
Philipp Maier