Attention is currently required from: laforge, pespin.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33197 )
Change subject: stream: Add server-side (segmentation) support for IPAC
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
IIUC, the only that actually matters here for the user
of the osmo_stream is adding a specific segme […]
This also determines that the IPA
specific read mode added in later commits of this patch series will be used. I could add
something like:
"Will also cause the stream backend to use the IPA-specific read mode added in change
<change hash>"
Concerning the design choice: I understood the task given to me as specifically adding
this functionality to the stream API. Maybe it's because IPA is widely used along
with the stream API by different upper layers (?)
I've CCed Daniel so he can chime in because he has the wide background knowledge to
the task.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/33197
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I6c91ff385cb5f36ab6b6c96d0e44997995d0d24c
Gerrit-Change-Number: 33197
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Jun 2023 14:24:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment