[M] Change in osmo-bsc[master]: nokia: rename BTS model from nokia_site to nokia-e1
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42729?usp=email ) Change subject: nokia: rename BTS model from nokia_site to nokia-e1 ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42729/comment/92c30ae9_f1740cf3?usp=... : PS2, Line 187: static const char *args[] = { "nokia-e1" };
`static const char *` array should probably be `static const char * const`
If I change that line to what the linter asks for, the result is compilation warning about discarding const qualifier: `cfg_bts_type()` function created by `DEFUN_USRATTR()` magic takes `const char **` rather than `const char * const*`. So what do we do? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42729?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3e993bda577964922e29dbbaf9554fa53bb2d445 Gerrit-Change-Number: 42729 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 06 May 2026 03:27:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
participants (1)
-
falconia