Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39948?usp=email ) Change subject: client: use pcap_dispatch to avoid extra pkt buffer copy ...................................................................... Patch Set 3: (2 comments) File src/osmo_client_core.c: https://gerrit.osmocom.org/c/osmo-pcap/+/39948/comment/05710340_3502942e?usp... : PS2, Line 464: one

Why not just passing `1`? It needs a value, not a pointer. Oh indeed, when I saw the example it was using a var so I thought it was similar to a setsockopt. I'll rework this.

https://gerrit.osmocom.org/c/osmo-pcap/+/39948/comment/1926672d_00e7004b?usp... : PS2, Line 464: == -1

Maybe it's better to check `!= 0` instead? Looking at the man page, I see it may return `PCAP_ERROR_ […] Will have a look thanks.

-- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I055efb66fac5e04c541d75ec2c0f654cdfb17838 Gerrit-Change-Number: 39948 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Tue, 08 Apr 2025 11:56:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>