Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/33538 )
Change subject: nacc_fsm: Add support for NACC with UTRAN and E-UTRAN cells
......................................................................
Patch Set 1:
(2 comments)
File src/nacc_fsm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8821):
https://gerrit.osmocom.org/c/osmo-pcu/+/33538/comment/00470315_cbadd494
PS1, Line 280: const Packet_Cell_Change_Notification_t * notif)
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-8821):
https://gerrit.osmocom.org/c/osmo-pcu/+/33538/comment/715e2232_cf45de54
PS1, Line 318: Target_Cell_4G_Notif;
Avoid multiple line dereference - prefer
'notif->Target_Cell.u.Target_Other_RAT_Notif.u.Target_Other_RAT_2_Notif.u.Target_Cell_4G_Notif'
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/33538
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I96280f0ec5955ed3cb17641bf4118496c929bdac
Gerrit-Change-Number: 33538
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 30 Jun 2023 14:37:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment