Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31751 ) Change subject: rlcmac: ul_tbf: Implement support for TBF Starting Time ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File include/osmocom/gprs/rlcmac/rlcmac_dec.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/31751/comment/30e692b6_0a4fd5e3 PS1, Line 8: #include <osmocom/gsm/gsm0502.h> : #include <osmocom/gsm/gsm_utils.h> Why are you including these headers? I guess because some stuff is needed for the `sched.h`? If so, then `sched.h` needs to be fixed to include the necessary headers. File src/rlcmac/rlcmac.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/31751/comment/7f30accc_32d83518 PS1, Line 194: uint32_t fn Unused? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31751 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Id81f16743f2c464e01caf27ba2eb8c0fc715fe8a Gerrit-Change-Number: 31751 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 08 Mar 2023 19:02:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment