fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42838?usp=email )

Change subject: server: fix misleading data length validation log message ......................................................................

server: fix misleading data length validation log message

The format string "%u < %u <= %u" was printed with arguments (min_len, data->len, max_len), placing the offending length in the middle and mislabeling it. This is confusing. Let's print the actual length followed by the expected interval instead.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com Change-Id: Ice95c1f8ad1aa8de259364bd70eba0db8918b19e --- M src/osmo_server_network.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/38/42838/1

diff --git a/src/osmo_server_network.c b/src/osmo_server_network.c index da14480..3ab2003 100644 --- a/src/osmo_server_network.c +++ b/src/osmo_server_network.c @@ -185,8 +185,8 @@ min_len = sizeof(struct osmo_pcap_pkthdr); max_len = conn->server->max_snaplen + sizeof(struct osmo_pcap_pkthdr); if (data->len < min_len || data->len > max_len) { - LOGP(DSERVER, LOGL_ERROR, "Implausible data length: %u < %u <= %u\n", - min_len, data->len, max_len); + LOGP(DSERVER, LOGL_ERROR, "Implausible data length %u, expected range [%u..%u]\n", + data->len, min_len, max_len); return -1; } return 0;