Attention is currently required from: fixeria, jolly, laforge, osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35172?usp=email ) Change subject: soft_uart: implement modem status lines and flow control ...................................................................... Patch Set 3: (4 comments) File include/osmocom/core/soft_uart.h: https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/1868fc74_0520d7cb PS3, Line 54: OSMO_SUART_STATUS_F_CTS = (1 << 5), /*!< Clear To Send */ (personally i prefer an enum storing just 0, 1, 2, 3, 4, 5, because it is easy to get from 5 to 1<<5, but it is hard to get from 0b0100000 to 5.) https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/4d979bcb_8280797d PS3, Line 61: OSMO_SUART_FLOW_CTRL_M_NONE, (apparently it's good practice to set the first item = 0 explicitly) https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/5624218e_614fba12 PS3, Line 100: gets wdym, "gets". it returns void? File src/core/soft_uart.c: https://gerrit.osmocom.org/c/libosmocore/+/35172/comment/c8ecb0f8_d64c2318 PS2, Line 398: if (active) /* assert the given line */

Logic 1 is negative voltage on RS232 level and is the de-asserted (disabled) level on control lines. re: if assert and de-assert is terminology from the matching spec, then of course keep using those terms here. (could have one comment in the first occurence to explain the term usage maybe)

-- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I26b93ce76f2f6b6fbf017f2684312007db3c6d48 Gerrit-Change-Number: 35172 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-CC: jolly <andreas@eversberg.eu> Gerrit-CC: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Fri, 01 Dec 2023 01:57:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith@sysmocom.de> Comment-In-Reply-To: jolly <andreas@eversberg.eu> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment