Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34514?usp=email ) Change subject: modem: grr: implement RACH.req retransmission ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File src/host/layer23/src/modem/grr.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34514/comment/ca25b113_7d402c9f PS2, Line 470: rr->n_chan_req = GRR_PACKET_ACCESS_MAX_CHAN_REQ; add "pending" word somewhere in the variable field? n_chan_req_pending. https://gerrit.osmocom.org/c/osmocom-bb/+/34514/comment/ff53a191_4ba95595 PS2, Line 659: static void grr_st_packet_access_action(struct osmo_fsm_inst *fi, I think it's the first place I see we add the "action" keyword, I was first confused about what was this. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34514?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Iab6d9147f6e0aeb99239affacf318a3897fd6ffe Gerrit-Change-Number: 34514 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Fri, 22 Sep 2023 23:12:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment