Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33995 )
Change subject: pcu: Split f_ms_tx_ul_data_block() into helper functions
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File pcu/GPRS_Components.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33995/comment/c874814c_28a0…
PS1, Line 672: blocks
Why "blocks" (plural), btw? I see this function is sending exactly one RLC/MAC
block.
Perhaps because one RLC/MAC can carry multiple LLC blocks (`record of LlcBlock`)?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33995
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I81176fa5c7caa2535bcc97eec26833579933ed7a
Gerrit-Change-Number: 33995
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 30 Jul 2023 08:51:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment