Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28161 ) Change subject: pySim-shell: add export option to add CREATE FILE APDUs ...................................................................... Patch Set 3: (1 comment) File pySim-shell.py: https://gerrit.osmocom.org/c/pysim/+/28161/comment/25da38a0_57e78b4d PS3, Line 556: self._cmd.poutput("apdu 00E00000%02x%s" % (int(len(self._cmd.rs.selected_file_fcp_hex)/2), str(self._cmd.rs.selected_file_fcp_hex)))

I would have preferred if we actually generate the 'create file' command here. […] I noticed that it is highly problematic to use the FCP that is coming back from the card to create the files. We should either abandon this or find a way to generate create file commandlines.

-- To view, visit https://gerrit.osmocom.org/c/pysim/+/28161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If529b86062f7c678c9c75f46ce9ca116cea8b47b Gerrit-Change-Number: 28161 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Wed, 01 Jun 2022 16:24:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Gerrit-MessageType: comment