laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/33226 ) Change subject: cosmetic: fix various typos in comments, log messages and VTY strings ...................................................................... cosmetic: fix various typos in comments, log messages and VTY strings Change-Id: I9a8afc07ae278100ffe34407db0e196f0c9ce8af --- M src/m3ua.c M src/osmo_ss7_vty.c M src/sccp_user.c M src/sua.c M src/xua_as_fsm.c M tests/vty/ss7_asp_test.vty 6 files changed, 21 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/m3ua.c b/src/m3ua.c index 63297fe..8d82522 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -504,7 +504,7 @@ return -1; /* send the msg to the AS for transmission. The AS FSM might - * (depending on its state) enqueue it before trnsmission */ + * (depending on its state) enqueue it before transmission */ rc = osmo_fsm_inst_dispatch(as->fi, XUA_AS_E_TRANSFER_REQ, msg); if (rc < 0) msgb_free(msg); diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index 0d15c52..541d197 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -211,7 +211,7 @@ "xua rkm routing-key-allocation (static-only|dynamic-permitted)", "SIGTRAN xxxUA related\n" "Routing Key Management\n" "Routing Key Management Allocation Policy\n" - "Only static (pre-confgured) Routing Keys permitted\n" + "Only static (pre-configured) Routing Keys permitted\n" "Dynamically allocate Routing Keys for what ASPs request\n", CMD_ATTR_IMMEDIATE) { @@ -514,7 +514,7 @@ DEFUN_ATTR(xua_accept_dyn_asp, xua_accept_dyn_asp_cmd, "accept-asp-connections (pre-configured|dynamic-permitted)", "Define what kind of ASP connections to accept\n" - "Accept only pre-confiugred ASPs (source IP/prt)\n" + "Accept only pre-configured ASPs (source IP/port)\n" "Accept any connection and dynamically create an ASP definition\n", CMD_ATTR_IMMEDIATE) { diff --git a/src/sccp_user.c b/src/sccp_user.c index a04a1c3..2be9cd4 100644 --- a/src/sccp_user.c +++ b/src/sccp_user.c @@ -646,7 +646,7 @@ asp->cfg.is_server = false; /* Make sure that the role of this ASP is set to ASP unless the user - * made a concious decision about the role via the VTY */ + * made a conscious decision about the role via the VTY */ if (!asp->cfg.role_set_by_vty) asp->cfg.role = OSMO_SS7_ASP_ROLE_ASP; diff --git a/src/sua.c b/src/sua.c index bd51005..a20d751 100644 --- a/src/sua.c +++ b/src/sua.c @@ -258,7 +258,7 @@ } /*********************************************************************** - * Transmitting SUA messsages to SCTP + * Transmitting SUA messages to SCTP ***********************************************************************/ static struct msgb *sua_to_msg(struct xua_msg *xua) @@ -316,7 +316,7 @@ return -1; /* send the msg to the AS for transmission. The AS FSM might - * (depending on its state) enqueue it before trnsmission */ + * (depending on its state) enqueue it before transmission */ rc = osmo_fsm_inst_dispatch(as->fi, XUA_AS_E_TRANSFER_REQ, msg); if (rc < 0) msgb_free(msg); @@ -324,7 +324,7 @@ } /*********************************************************************** - * Receiving SUA messsages from SCTP + * Receiving SUA messages from SCTP ***********************************************************************/ /*! \brief Decode SUA Global Title according to RFC3868 Section 3.10.2.3 @@ -427,7 +427,7 @@ * probably want to have a separate general parsing function storing * the subparts in xua_msg_part. But before we do, we should find more * users of this subpart parsing and be aware of the performance - * tradeoff. + * trade-off. */ while (pos + sizeof(*par) < param->len) { @@ -619,7 +619,7 @@ if (ntfy.info_string) talloc_free(ntfy.info_string); - /* TODO: should we report this soemwhere? */ + /* TODO: should we report this somewhere? */ return 0; } @@ -680,7 +680,7 @@ OSMO_ASSERT(asp->cfg.proto == OSMO_SS7_ASP_PROT_SUA); /* caller owns msg memory, we shall neither free it here nor - * keep references beyon the execution of this function and its + * keep references beyond the execution of this function and its * callees. */ if (!asp->inst->sccp) { diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c index 2f52762..2b16139 100644 --- a/src/xua_as_fsm.c +++ b/src/xua_as_fsm.c @@ -80,7 +80,7 @@ { unsigned int i; - /* this is a bit tricky. "osmo_ss7_as" has no configuation of a role, + /* this is a bit tricky. "osmo_ss7_as" has no configuration of a role, * only the ASPs have. As they all must be of the same role, let's simply * find the first one and return its role */ for (i = 0; i < ARRAY_SIZE(as->cfg.asps); i++) { diff --git a/tests/vty/ss7_asp_test.vty b/tests/vty/ss7_asp_test.vty index 14ca25a..5faabd9 100644 --- a/tests/vty/ss7_asp_test.vty +++ b/tests/vty/ss7_asp_test.vty @@ -135,7 +135,7 @@ ss7_asp_vty_test(config-cs7)# xua rkm ? routing-key-allocation Routing Key Management Allocation Policy ss7_asp_vty_test(config-cs7)# xua rkm routing-key-allocation ? - static-only Only static (pre-confgured) Routing Keys permitted + static-only Only static (pre-configured) Routing Keys permitted dynamic-permitted Dynamically allocate Routing Keys for what ASPs request ss7_asp_vty_test(config-cs7)# asp ? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/33226 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I9a8afc07ae278100ffe34407db0e196f0c9ce8af Gerrit-Change-Number: 33226 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged