Attention is currently required from: jolly, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33511 ) Change subject: ASCI: Add call control for VGCS/VBS ...................................................................... Patch Set 12: (5 comments) File src/libmsc/msc_vgcs.c: https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/086378ee_878bd8bb PS12, Line 224: static uint8_t _rx_callref(uint8_t *ie, unsigned int remaining_len, uint32_t *callref, bool *with_prio, uint8_t *prio) so the function returns uint8_t, but you are using "return _msg_too_short()", which might retunr -EINVAL. That won't work. You need to make _rx_callref return an int type ,and make sure at all callers to check for negative return values https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/81c2337f_968fd380 PS12, Line 364: _rx_callref return value could be negative https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/869b8cbc_c61f8e81 PS12, Line 398: ie = (da << 3) | (ua << 2) | (comm << 1) | oi; : msgb_put_u8(msg, ie); depending on your taste, this could of course be wrapped in one line like msgb_put_u8(msg, (da << 3) | (ua << 2) | (comm << 1) | oi); My earlier comment "use a stack variable" was assuming there might be multiple steps to put together the uint8_t value, which might be more convoluted than or-ing a few values. I still like the current code as it is explicit, but just clarifying my earlier comment. https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/02f7a0b4_b408e1b2 PS12, Line 423: _rx_callref negative return value https://gerrit.osmocom.org/c/osmo-msc/+/33511/comment/425184ce_263b10f6 PS12, Line 536: ie_len = _rx_callref(ie, remaining_len, callref, with_prio, prio); negative return value -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9947403fde8212b66758104443c60aaacc8b1e7b Gerrit-Change-Number: 33511 Gerrit-PatchSet: 12 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Sun, 09 Jul 2023 07:49:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment