[M] Change in pysim[master]: filesystem: edit_{binary,record}_decoded: add encode/decode examples
Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42552?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: filesystem: edit_{binary,record}_decoded: add encode/decode examples ...................................................................... filesystem: edit_{binary,record}_decoded: add encode/decode examples When invoking `edit_binary_decoded` or `edit_record_decoded`, the temp file opened in the editor now contains the EF's encode/decode test vectors as //-comment lines below the JSON content, similar to how 'git commit' appends comments to the commit message template. The comment block is stripped before JSON parsing on save, so it has no effect on the written data. The feature is implemented via a new module-level JsonEditor context manager class that encapsulates the full edit cycle: * write JSON + examples to a TemporaryDirectory * invoke the editor * read back, strip //-comments, parse and return the result Change-Id: I5a046a9c7ba7e08a98cf643d5a26bc669539b38f Related: OS#6900 --- M pySim/filesystem.py 1 file changed, 64 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/52/42552/4 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42552?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5a046a9c7ba7e08a98cf643d5a26bc669539b38f Gerrit-Change-Number: 42552 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
participants (1)
-
fixeria