Attention is currently required from: fixeria, pespin.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/30363 )
Change subject: paging: Split paging queue into 2 queues: initial and retrans
......................................................................
Patch Set 1:
(2 comments)
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/d351c158_d59e1745
PS1, Line 1045: static void paging_dump_vty(struct vty *vty, struct gsm_paging_request
*pag)
: {
: vty_out(vty, "Paging on BTS %u%s", pag->bts->nr,
VTY_NEWLINE);
: bsc_subscr_dump_vty(vty, pag->bsub);
: }
:
: static void bts_paging_dump_vty(struct vty *vty, struct gsm_bts *bts)
: {
: struct gsm_paging_request *pag;
:
: llist_for_each_entry(pag, &bts->paging.initial_req_list, entry)
: paging_dump_vty(vty, pag);
: llist_for_each_entry(pag, &bts->paging.retrans_req_list, entry)
: paging_dump_vty(vty, pag);
minor (can be follow-up patch): It might make sense to extend the vty dumping with some
information whether the entry is on the initial or the re-transmit list?
File src/osmo-bsc/paging.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/40461a27_2eb328c6
PS1, Line 216: page_ms(request);
spacing issues
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/30363
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747
Gerrit-Change-Number: 30363
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 30 Nov 2022 12:43:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment