Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42301?usp=email )
Change subject: pySim/transport: fix GET RESPONSE behaviour ......................................................................
Patch Set 7:
(2 comments)
File pySim/transport/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/42301/comment/d2ccb2eb_b9eeffcc?usp=ema... : PS2, Line 328: le_gr = '00'
What confuses me here is that the spec also mentions a 9xxx (but not 9000, and presumably also 9100 […]
I think we should skip this open question. As it seems, the spec describes some application specific corner-case.
File pySim/transport/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/42301/comment/1c58f680_9f3b9ed0?usp=ema... : PS6, Line 308: if sw is not None:
Quite a lot of nesting here... […]
I have now reduced the nesting by one level. Do you think this is sufficient?
-
dexter