Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28844 ) Change subject: Introduce libsmpputil ...................................................................... Patch Set 7: (2 comments) This change is ready for review. File include/osmocom/msc/smpp.h: https://gerrit.osmocom.org/c/osmo-msc/+/28844/comment/a6a5bac6_08ba56c4 PS2, Line 5: //Length limits according to SMPP 3.4 spec including NUL-byte:

/* */ Done

File src/utils/Makefile.am: https://gerrit.osmocom.org/c/osmo-msc/+/28844/comment/d6bfffb5_35c97dac PS2, Line 32: $(top_srcdir)/src/libmsc/smpp_smsc.h \

it may make sense to define a new SMPP_UTIL_HEADERS with this file, and include SMPP_UTILS_HEADERS h […] Given it's internal build-time optional library I don't think it's worth the effort.

-- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28844 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I61910651bc7c188dc2fb67d96189a66a47e7e8fb Gerrit-Change-Number: 28844 Gerrit-PatchSet: 7 Gerrit-Owner: msuraev <msuraev@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Sat, 30 Jul 2022 09:03:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment