laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/33866 ) Change subject: simtrace2-cardem-pcsc: mark reset events in GSMTAP trace ...................................................................... simtrace2-cardem-pcsc: mark reset events in GSMTAP trace At the moment only APDUs are logged to GSMTAP. It is not uncommon that a card is resetted by the UE multiple times during normal operation. When the trace lacks the reset events (ATR) it becomes difficult to follow in which state the card actually is. Let't mark reset events by sending the ATR via GSMTAP (like simtrace2_sniff already does it) Related: OS#6094 Change-Id: I6b4d82b6ee369c95eeca8f7d59478452395fbe54 --- M host/src/simtrace2-cardem-pcsc.c 1 file changed, 19 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/host/src/simtrace2-cardem-pcsc.c b/host/src/simtrace2-cardem-pcsc.c index 374966d..4acf268 100644 --- a/host/src/simtrace2-cardem-pcsc.c +++ b/host/src/simtrace2-cardem-pcsc.c @@ -106,6 +106,9 @@ LOGCI(ci, LOGL_NOTICE, "%s Resetting card in reader...\n", reset == COLD_RESET ? "Cold" : "Warm"); osim_card_reset(card, reset == COLD_RESET ? true : false); + + /* Mark reset event in GSMTAP wireshark trace */ + osmo_st2_gsmtap_send_apdu(GSMTAP_SIM_ATR, card->atr, card->atr_len); } last_status_flags = flags; -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/33866 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I6b4d82b6ee369c95eeca8f7d59478452395fbe54 Gerrit-Change-Number: 33866 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: tsaitgaist <kredon@sysmocom.de> Gerrit-MessageType: merged