Attention is currently required from: dexter, fixeria, laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email ) Change subject: [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 7: (3 comments) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/2c294888_fba24441?usp=ema... : PS6, Line 117: If self.value is None, first call self.validate() to generate a sanitized self.value from self.input_value.

I see how this creates a misunderstanding: I always write API docs in the "imperative mood", which i […] Done

File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/0538f7c2_358f139f?usp=ema... : PS7, Line 67: =

shouldn't that be a double-equals (also below)? to me it looks like an assignment rather than a com […] wow, a log string in a printf in example code in an api comment ... =) but ok

https://gerrit.osmocom.org/c/pysim/+/39742/comment/d5946cd5_28545b40?usp=ema... : PS7, Line 100: allow_types = (str, int, )

Does the comma with empty element imply that None is a vaid input value? In that case, I'd prefer a […] no, the trailing comma does not add a third item. It's just that i like trailing commas for easier editing and use them where i can.

Also I have this behavior from: a single-entry list *does* work as my_list = [foo], but tuple braces don't. This makes a single-entry tuple: my_tuple = (23, ) another_tuple = tuple((23, )) This not: not_my_tuple = (23) # an int also_not = tuple(23) # TypeError -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Sat, 19 Apr 2025 21:17:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: dexter <pmaier@sysmocom.de>