Attention is currently required from: dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/34059 )
Change subject: pcu_sock: use PCU_IF_SAPI_AGCH_2 instead PCU_IF_SAPI_AGCH
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bts/+/34059/comment/f823304c_8e9ec908
PS4, Line 14: CAUTION: This patch breaks compatibility to current master osmo-pcu (See
: also "Depends")
What do you think? Shall we bump the version to v.12
here now (osmo-ttcn3-hacks would require a follow up patch)
Ideally, yes. But there have already been some turbulence within PCUIFv11, so I guess
it's too late and bumping the version [again] would create even more
turbulence/confusion.
[...] in the future apply the policy that the version
number must be bumped as soon as a detail in PCUIF changes
I believe this policy is not new and was followed before PCUIFv11.
But yes, we should definitely stick to this policy.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/34059
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I29858fa20ad8bd0aefe81a5c40ad77a2559a8c10
Gerrit-Change-Number: 34059
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 31 Aug 2023 15:05:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment