Attention is currently required from: Hoernchen, fixeria, laforge.

Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email )

Change subject: transceiver: add optional WebSDR device support ......................................................................

Patch Set 12:

(11 comments)

File Transceiver52M/Transceiver.h:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/583bde8c_2a92ac44?usp=... : PS12, Line 246: int driveReceiveRadioShortVector(std::vector<short *> &bufs, int samples, int underrun, please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/1d0d29e3_100e0cc3?usp=... : PS12, Line 247: TIMESTAMP ts, unsigned samples_skipped); code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/54d668bd_9982859b?usp=... : PS12, Line 249: bool driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/9634dc63_906b90d5?usp=... : PS12, Line 265: ssize_t driveReceiveFIFOBurst(size_t chan, char *burstBuffer, size_t burstBufferLen); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/14c3478c_5999ab1f?usp=... : PS12, Line 271: @brief modulation and sorting of GSM bursts from GSM core please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/2800b8e7_1bc0808a?usp=... : PS12, Line 272: @param chan channel number please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/d7dd61a6_479f626a?usp=... : PS12, Line 273: @param burstBuffer optional buffer containing burst to transmit, if not provided, will read from data socket please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/327dc68e_240e5eb9?usp=... : PS12, Line 274: @param burstBufferLen optional length of burst buffer, if not provided, will read from data socket please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/45729f65_9659be64?usp=... : PS12, Line 277: bool driveTxPriorityQueue(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0); please, no spaces at the start of a line

File Transceiver52M/radioInterface.h:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/48549833_b9f8280d?usp=... : PS12, Line 118: int driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/ad38529c_4e5207b9?usp=... : PS12, Line 137: int fillPullBuffer(std::vector<short *> &bufs, size_t samples, int recvunderrun, TIMESTAMP ts); please, no spaces at the start of a line