Attention is currently required from: fixeria, pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/docker-playground/+/35159?usp=email )
Change subject: ttcn3-pcu-test/sns: fix PCUIF version number (follow up patch)
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
In general I'd prefer having v12 (newest version)
configured everywhere and sed it to 10 or 11 on th […]
Let's address this is in
a follow up patch. This patch makes jenkins-sns.sh, equal to jenkins.sh. I think this is
an improvement.
We then might consider to set the version to something like "XX" in the configs
and put a comment next to it that the version number is set in the jenkins(-sns).sh
scripts. And then we explicitly set the version number for each variant (master, latest,
2323q3 etc.)
--
To view, visit
https://gerrit.osmocom.org/c/docker-playground/+/35159?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I1f94a0459e35d7b5632c81d7f7e2e60eb0d0229f
Gerrit-Change-Number: 35159
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Nov 2023 14:12:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment