Attention is currently required from: Timur Davydov. laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email ) Change subject: trx, bts: add optional WebSDR backend (callback-based transport) ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: I really dislike the enormous amount of ifdef's sprinkled all over the code. It makes the code unreadable and hard to maintain. I would muhc rather prefer an approach where implementation A and B would sit in separate files, eahc providing the same symbols/functions. And then at compile time depending on the implementation, either file A or file B is compiled + linked. Or if needed some kind of dispatch based on structures of function pointers - but that introduces overhead at runtime and would only be needed if switching at runtime was an option (not needed here). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Idebd588f33afd85021813ad5821391781db683a9 Gerrit-Change-Number: 42703 Gerrit-PatchSet: 11 Gerrit-Owner: Timur Davydov <dtv.comp@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: Timur Davydov <dtv.comp@gmail.com> Gerrit-Comment-Date: Wed, 06 May 2026 08:00:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No