Attention is currently required from: Timur Davydov.
laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42703?usp=email )
Change subject: trx, bts: add optional WebSDR backend (callback-based transport) ......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS11: I really dislike the enormous amount of ifdef's sprinkled all over the code. It makes the code unreadable and hard to maintain. I would muhc rather prefer an approach where implementation A and B would sit in separate files, eahc providing the same symbols/functions. And then at compile time depending on the implementation, either file A or file B is compiled + linked. Or if needed some kind of dispatch based on structures of function pointers - but that introduces overhead at runtime and would only be needed if switching at runtime was an option (not needed here).