Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/38894?usp=email ) Change subject: stream_srv: Add osmo_stream_srv_link_set_{ip_dscp,priority}() APIs ...................................................................... Patch Set 4: (2 comments) File src/stream_srv.c: https://gerrit.osmocom.org/c/libosmo-netif/+/38894/comment/ce14fd34_96d8f5e7... : PS4, Line 165: %u)

`%d`? Done

https://gerrit.osmocom.org/c/libosmo-netif/+/38894/comment/5c9976b1_9a25853c... : PS4, Line 258: return 0;

No, I prefer keeping with a return in case we want to add some sort of param check or set it through […] Done

-- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/38894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Iacb6b72a05055820253eaaa04850637dd2fc20e9 Gerrit-Change-Number: 38894 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 10:16:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de>