Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42836?usp=email ) Change subject: vty: clamp configured snaplen to the wire-framing limit ...................................................................... Patch Set 1: (3 comments) File include/osmo-pcap/common.h: https://gerrit.osmocom.org/c/osmo-pcap/+/42836/comment/e7d701fc_01f3b7e4?usp... : PS1, Line 70: #define OSMO_PCAP_MAX_SNAPLEN 65535

can we then set it to UINT16_MAX here? Done

File src/osmo_client_vty.c: https://gerrit.osmocom.org/c/osmo-pcap/+/42836/comment/0b01a86d_8bc0a6ce?usp... : PS1, Line 202: "Bytes (effectively limited to 64 KiB by the osmo-pcap wire framing)\n")

Can you add the exact integer number here instead of 64KiB so user actually knows what to set it to? Done

File src/osmo_server_vty.c: https://gerrit.osmocom.org/c/osmo-pcap/+/42836/comment/c72c1cea_ea00f0ed?usp... : PS1, Line 377: "Bytes (effectively limited to 64 KiB by the osmo-pcap wire framing)\n")

Can you add the exact integer number here instead of 64KiB so user actually knows what to set it to? Done

-- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42836?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ia56cad48e8cefe8ae103f2f7d2e037bf28438b71 Gerrit-Change-Number: 42836 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Sat, 20 Jun 2026 23:00:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>