Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42836?usp=email )

Change subject: vty: clamp configured snaplen to the wire-framing limit ......................................................................

Patch Set 1:

(3 comments)

File include/osmo-pcap/common.h:

https://gerrit.osmocom.org/c/osmo-pcap/+/42836/comment/e7d701fc_01f3b7e4?usp... : PS1, Line 70: #define OSMO_PCAP_MAX_SNAPLEN 65535

can we then set it to UINT16_MAX here?

Done

File src/osmo_client_vty.c:

https://gerrit.osmocom.org/c/osmo-pcap/+/42836/comment/0b01a86d_8bc0a6ce?usp... : PS1, Line 202: "Bytes (effectively limited to 64 KiB by the osmo-pcap wire framing)\n")

Can you add the exact integer number here instead of 64KiB so user actually knows what to set it to?

Done

File src/osmo_server_vty.c:

https://gerrit.osmocom.org/c/osmo-pcap/+/42836/comment/c72c1cea_ea00f0ed?usp... : PS1, Line 377: "Bytes (effectively limited to 64 KiB by the osmo-pcap wire framing)\n")

Can you add the exact integer number here instead of 64KiB so user actually knows what to set it to?

Done