Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-trx/+/43612?usp=email )
Change subject: proxy: queue BURST.req and dispatch per TDMA frame tick ......................................................................
Patch Set 2:
(2 comments)
File proxy/src/burst_fwd.c:
https://gerrit.osmocom.org/c/osmo-trx/+/43612/comment/d1fff980_89feedd7?usp=... : PS2, Line 151: llist_for_each_entry(cur, &c->tx_burst_queue, list) { I guess 99.9999% of the time the bursts will arrive in order, which means probably iterating from the end of the queue towards the start makes sense. Or a t least have a fast path simply testing last value in the list.
https://gerrit.osmocom.org/c/osmo-trx/+/43612/comment/b46e64f0_9f6264be?usp=... : PS2, Line 251: if (rc < 0) { /* br->fn is behind fn */ OSMO_UNLIKELY()
-
pespin