Attention is currently required from: falconia.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/42604?usp=email )

Change subject: firmware/se_k2xx: add board specific RF tables ......................................................................

Patch Set 2:

(2 comments)

Patchset:

PS2:

You should also add reading of per-unit RF calibration tables from TIFFS, like it is done on gta0x a […]

This is already implemented and working. Here's the firmware boot log for K2xx:

``` Checking TIFFS for the RF calibration records Found '/gsm/rf/afcdac', applying Found '/gsm/rf/tx/ramps.900', applying Found '/gsm/rf/tx/levels.900', applying Found '/gsm/rf/tx/calchan.900', applying Found '/gsm/rf/tx/ramps.1800', applying Found '/gsm/rf/tx/levels.1800', applying Found '/gsm/rf/tx/calchan.1800', applying ```

File src/target/firmware/board/se_k2xx/rf_tables.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/42604/comment/d39efbe1_224b7bab?us... : PS2, Line 30: uint8_t apc_offset = 48;

If you look at `reg-read` file in the same directory where you found rf_XXX. […]

Just to clarify: `APCOFF = 0x07F` is 127 in decimal, but you suggest 63. How did you calculate that value? I assume you used some formula, so I trust you here and modified the patch to use 63 and added a comment that it's derived from `APCOFF`.