[M] Change in pysim[master]: personalization: implement reading back values from a PES - gerrit-log

24 Apr 2026


      Attention is currently required from: fixeria, laforge, neels.
dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40198?usp=email )
Change subject: personalization: implement reading back values from a PES
......................................................................
Patch Set 14: Code-Review+2
(1 comment)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/40198/comment/8e522c34_82c4f429?usp=ema... :
PS13, Line 410:             acc_f = pe.files.get('ef-acc', None)
...
Apparently we are doing nothing with acc_f but I can see that in the following patch acc_f is used. […]
(we probably better skip this as it is only a cosmetic suggestion)
-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/40198?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I234fc4317f0bdc1a486f0cee4fa432c1dce9b463
Gerrit-Change-Number: 40198
Gerrit-PatchSet: 14
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Fri, 24 Apr 2026 08:23:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: dexter pmaier@sysmocom.de