Attention is currently required from: Hoernchen, osmith, pespin. fixeria has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email ) Change subject: build: install common/GSM/transceiver libraries for emscripten and add pkg-config files ...................................................................... Patch Set 1: (1 comment) File Transceiver52M/arch/common/Makefile.am: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/fed757d5_931117b9?usp=... : PS1, Line 16: NOT_HAVE_EMSCRIPTEN I believe you can re-use `HAVE_EMSCRIPTEN` here: ```suggestion if !HAVE_EMSCRIPTEN ``` According to https://www.gnu.org/software/automake/manual/html_node/Usage-of-Conditionals..., this seems to be a valid syntax. You can then remove `NOT_HAVE_EMSCRIPTEN`. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c Gerrit-Change-Number: 42243 Gerrit-PatchSet: 1 Gerrit-Owner: Timur Davydov <dtv.comp@gmail.com> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: Hoernchen <ewild@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 02 Mar 2026 11:39:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No