Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30290 ) Change subject: trxcon: trx_data_rx_cb(): check TRXD PDU version ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/host/trxcon/src/trx_if.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30290/comment/67404041_2fd12869 PS1, Line 651: if ((buf[0] >> 4) != 0) { if (buf[0] & 0xf0) { } sounds far more easy to follow imho. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If5687d7d87619c0da02cc81ab26d63e61484bc06 Gerrit-Change-Number: 30290 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 24 Nov 2022 11:08:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment