Attention is currently required from: laforge, pespin. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882?usp=email ) Change subject: ctrl, hnbgw: access rate counter groups by given ID instead of index ...................................................................... Patch Set 4: (1 comment) Patchset: PS2:

you are missing the use of array indexes in this API verifying rate counters via the ctrl interface. […] I thought some more about this, and a nicer API would actually be one where the object identification is also part of the array entry. It could be a string, then callers could enter "msc.0" or "hnb.by_name.A1B2C3".

That would be nice, but I currently prefer not to spend time on our testing API cosmetics, and just use this patch that is quickest to success. There is another compound to this: when we revert this patch to osmo-hnbgw https://gerrit.osmocom.org/c/osmo-hnbgw/+/38002 then the object identification behavior does not change, and we don't currently need these patches here applied at all to fix our test suite. (The general mismatch of using "obj.N" for volatile objects still exists, but it would not show in the test suite, because osmo-hnbgw will always snap back to hnb.0.) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I70e74e7554482df67aa1d90bc04314124dea444f Gerrit-Change-Number: 37882 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 04 Sep 2024 21:41:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de>