Attention is currently required from: fixeria, jolly. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email ) Change subject: ss7_asp_peer: Improvements in ss7_asp_peer_snprintf() ...................................................................... Patch Set 1: (1 comment) File src/ss7_asp_peer.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753/comment/74359cc9_d2cbc2... : PS1, Line 68: peer->host[0],

What if `peer->host[0]` is an IPv4 address, but `peer->host[N]` (N > 0) is an IPv6?Also, I see below […] I was missing an "else if" here, which is already present in

osmo_multiaddr_ip_and_port_snprintf(), my bad. Regarding IPv6 "[]", it is only needed in the case where host_cnt == 1, because when >1 there's already a "(...|...)" separating the IP address from the ":port". -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I115951627adb0c6778a9a36159237c3eea130300 Gerrit-Change-Number: 43753 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Fri, 02 Oct 2026 11:13:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>