Attention is currently required from: jolly, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34478?usp=email ) Change subject: ASCI: MM connections are defined by 'ref' and 'protocol' tuple ...................................................................... Patch Set 5: (2 comments) File src/host/layer23/src/mobile/gsm48_mm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34478/comment/9fe16cec_b766af37 PS5, Line 1427: uint32_t ref, uint16_t class)

using "class" as param name is asking for trouble eg. […] Ack

https://gerrit.osmocom.org/c/osmocom-bb/+/34478/comment/b3d1522a_f17b8602 PS5, Line 1449: LOGP(DMM, LOGL_ERROR, "Invalid message class 0x%x. Please fix!", class);

0x02%x? Ack

-- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34478?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic280cd8c666660077bb2c2ef641f4cddd3b36eee Gerrit-Change-Number: 34478 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Sun, 24 Sep 2023 17:43:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment