Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33133 ) Change subject: cnpool: extract Mobile Identity from RANAP payload ...................................................................... Patch Set 2: (3 comments) File src/osmo-hnbgw/hnbgw_l3.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/33133/comment/80deffe1_565dfd7e PS2, Line 1: /* OsmoHNBGW implementation of CS and PS Level3 message decoding (NAS PDU */

missing ")" Done

https://gerrit.osmocom.org/c/osmo-hnbgw/+/33133/comment/701b23d3_d105c36a PS2, Line 104: /* Old routing area identification 10.5.5.15. */

ack, thx. […] problem, gsm48_parse_ra() returns struct gprs_ra_id, but i want struct osmo_routing_area_id, which uses struct osmo_plmn_id so that I can use osmo_plmn_cmp() on it... seems we have a bit of code split.

i guess there could be one static function for decoding old RA id for here and below? cannot find a public API function for struct osmo_routing_area_id. any better ideas...? https://gerrit.osmocom.org/c/osmo-hnbgw/+/33133/comment/6768f7a6_b881cb6c PS2, Line 132: /* Old routing area identification 10.5.5.15 */

gsm48_parse_ra (same as above)

-- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I373d665c9684b607207f68094188eab63209db51 Gerrit-Change-Number: 33133 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 05 Jun 2023 13:06:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment