[M] Change in osmo-ttcn3-hacks[master]: stp: Allow setting up different m3ua_config list by test
Attention is currently required from: daniel, fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39641?usp=email ) Change subject: stp: Allow setting up different m3ua_config list by test ...................................................................... Patch Set 1: (2 comments) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39641/comment/0c76976a_ee534... : PS1, Line 47: /* Clients first, servers afterwards, match mp_m3ua_num_{clients,servers} */
maybe add an explicit check for this? There's no way to check, it is just how it expected to be processed.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39641/comment/9b95c1c7_3914b... : PS1, Line 135: g_m3ua_num_clients
is _clients correct here, or should it be _servers? _clients is fine, since servers start after clients.
-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39641?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0a875bac5e9506be9140d5afa28da25bdc99a5a6 Gerrit-Change-Number: 39641 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Fri, 28 Feb 2025 12:30:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith@sysmocom.de>
participants (1)
-
pespin