Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35123?usp=email ) Change subject: Add a GSM RLP decoder and encoder ...................................................................... Patch Set 2: (6 comments) File include/osmocom/gsm/rlp.h: https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/e6e943e7_0d077a3a PS2, Line 24: GSM A5 ciphering algorithm copy-paste https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/db8bb2e2_82c0f279 PS2, Line 28: 24.002 It should actually be TS 24.022. https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/4d173cf8_6ad9a36f PS2, Line 75: osmo_rlp_decode also expose `osmo_rlp_encode`? File src/gsm/libosmogsm.map: https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/9ecd737a_db24db2c PS2, Line 863: osmo_rlp_decode also expose `osmo_rlp_encode`? File src/gsm/rlp.c: https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/e86caeff_197bfc48 PS2, Line 77: EINVAL `ENOTSUP` https://gerrit.osmocom.org/c/libosmocore/+/35123/comment/3c8d5198_9efab098 PS2, Line 121: EINVAL `ENOTSUP` -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d9bd8eb4f0cd0f72c436996767b199429596917 Gerrit-Change-Number: 35123 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Fri, 24 Nov 2023 07:42:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment